Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messages passing in conversations #1726

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 24, 2024

Important

In retrieval_service.py, agent() now fetches conversation messages using get_conversation() and removes unused imports.

  • Behavior:
    • In retrieval_service.py, agent() now uses get_conversation() instead of get_conversations_overview() to fetch conversation messages.
    • Processes conversation_messages directly, appending them to messages.
  • Imports:
    • Removed unused imports: EmbeddingPurpose, GraphSearchSettings, and SearchMode from retrieval_service.py.

This description was created by Ellipsis for ab61ad5. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ab61ad5 in 19 seconds

More details
  • Looked at 40 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/services/retrieval_service.py:310
  • Draft comment:
    Consider adding a return statement or raising an exception after logging the error to prevent further execution when conversation_messages retrieval fails.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_HSESGkSEAmjFBbj7


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit e0e0eaa into main Dec 24, 2024
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/FixConversationMessages branch December 24, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant