Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS route examples #1725

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Update JS route examples #1725

merged 1 commit into from
Dec 24, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 24, 2024

Important

Update JavaScript route examples in retrieval_router.py to use camelCase for consistency.

  • JavaScript Route Examples:
    • Updated JavaScript examples in retrieval_router.py to use camelCase.
    • Renamed use_semantic_search to useSemanticSearch.
    • Renamed chunk_settings to chunkSettings.
    • Renamed graph_settings to graphSettings.
    • Renamed rag_generation_config to ragGenerationConfig.
    • Renamed max_tokens to maxTokens.

This description was created by Ellipsis for 9cfe38d. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9cfe38d in 18 seconds

More details
  • Looked at 73 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. py/core/main/api/v3/retrieval_router.py:142
  • Draft comment:
    Consider updating use_semantic_search to useSemanticSearch for consistency with JavaScript naming conventions. This applies to other instances in the Python and Shell examples as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates JavaScript examples to use camelCase for consistency with JavaScript naming conventions. However, there are still instances of snake_case in the Python and Shell examples that should be updated for consistency.
2. py/core/main/api/v3/retrieval_router.py:316
  • Draft comment:
    Consider updating use_semantic_search to useSemanticSearch for consistency with JavaScript naming conventions. This applies to other instances in the Python and Shell examples as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates JavaScript examples to use camelCase for consistency with JavaScript naming conventions. However, there are still instances of snake_case in the Python and Shell examples that should be updated for consistency.
3. py/core/main/api/v3/retrieval_router.py:508
  • Draft comment:
    Consider updating use_semantic_search to useSemanticSearch for consistency with JavaScript naming conventions. This applies to other instances in the Python and Shell examples as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates JavaScript examples to use camelCase for consistency with JavaScript naming conventions. However, there are still instances of snake_case in the Python and Shell examples that should be updated for consistency.

Workflow ID: wflow_cLZTCyT0P7ti2KGf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 8792d54 into main Dec 24, 2024
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/JsExamples branch December 24, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant