Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JS SDK to camel case #1724

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Move JS SDK to camel case #1724

merged 1 commit into from
Dec 24, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 24, 2024

Important

Convert JavaScript SDK to camelCase naming conventions and add utility functions for key conversion.

  • Behavior:
    • Convert all object keys and variable names from snake_case to camelCase in js/sdk/src/types.ts.
    • Update baseClient.ts to use ensureCamelCase for response data.
    • Modify ChunksClient, RetrievalClient, and UsersClient to use ensureSnakeCase for request data.
  • Utilities:
    • Add ensureCamelCase and ensureSnakeCase functions in typeTransformer.ts for key conversion.
    • Export utility functions in index.ts.
  • Tests:
    • Add tests for ensureCamelCase and ensureSnakeCase in typeTransformer.test.ts.
    • Update integration tests in __tests__ to reflect camelCase changes.

This description was created by Ellipsis for f80653b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f80653b in 1 minute and 36 seconds

More details
  • Looked at 1413 lines of code in 17 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. js/sdk/src/v3/clients/users.ts:187
  • Draft comment:
    Use camelCase for consistency.
        response.results.accessToken.token,
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. js/sdk/src/v3/clients/users.ts:188
  • Draft comment:
    Use camelCase for consistency.
        response.results.refreshToken.token,
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_rpY4Cmve6vZh28Rf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 4e3c608 into main Dec 24, 2024
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/CamelCaseJS branch December 24, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant