Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure name and bio are returned with user, clean up typing across auth #1722

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 23, 2024

Important

Ensure name and bio are returned in user operations and improve typing across authentication modules.

  • Behavior:
    • Ensure name and bio are returned in user-related operations in users.py and users_router.py.
    • Add name, bio, and profile_picture to user overview in users.py.
  • Typing and Code Clarity:
    • Improve typing in auth_service.py, r2r_auth.py, and users_router.py.
    • Use UUID for key_id in auth_service.py and r2r_auth.py.
    • Add type: ignore comments for type checking in users_router.py.
  • Tests:
    • Update UsersIntegrationSuperUser.test.ts to check for name and bio in user responses.
  • Misc:
    • Remove unused arguments in management_service.py.

This description was created by Ellipsis for 0707d59. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to fcf82dd in 1 minute and 7 seconds

More details
  • Looked at 551 lines of code in 8 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. js/sdk/__tests__/UsersIntegrationSuperUser.test.ts:31
  • Draft comment:
    Commented-out assertions should be either removed or uncommented based on their necessity. Leaving them commented can lead to confusion and maintenance issues. This applies to lines 31, 33, and 34.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The test file contains commented-out assertions that should be either removed or uncommented based on their necessity. Leaving them commented can lead to confusion and maintenance issues.
2. py/core/main/api/v3/users_router.py:1410
  • Draft comment:
    Avoid using # type: ignore to suppress type checking errors. Address the root cause of these errors to prevent hiding potential issues. This applies to lines 1410, 1467, and 1531.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The # type: ignore comments are used to suppress type checking errors. It's better to address the root cause of these errors rather than suppressing them, as it can hide potential issues.
3. py/core/main/services/auth_service.py:291
  • Draft comment:
    The key_id parameter is documented as a str but is actually a UUID. Update the docstring to reflect the correct type.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The delete_user_api_key function in auth_service.py has a parameter key_id that is documented as a str but is actually a UUID. This discrepancy should be corrected in the docstring.
4. py/core/main/services/auth_service.py:283
  • Draft comment:
    The key_id parameter is documented as a str but is actually a UUID. Update the docstring to reflect the correct type.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The delete_user_api_key function in auth_service.py has a parameter key_id that is documented as a str but is actually a UUID. This discrepancy should be corrected in the docstring.

Workflow ID: wflow_EsJJjsq3NWLV1IJm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 805114c into main Dec 23, 2024
15 checks passed
@NolanTrem NolanTrem deleted the Nolan/UserCleanup branch December 23, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant