Allow setting conversation name in conversation.create

[NolanTrem]

Important

Add support for setting and updating conversation names in creation and update operations across backend and frontend.

• Behavior:
  • Allow setting a conversation name in conversations.create() and conversations.update() in conversations.ts and conversations.py.
  • Update create_conversation and update_conversation endpoints in conversations_router.py to accept a name parameter.
• Database:
  • Modify create_conversation and update_conversation in conversations.py to handle name and raise HTTPException on failure.
• Tests:
  • Add tests for creating and updating a conversation with a name in ConversationsIntegrationSuperUser.test.ts.
• Misc:
  • Remove unused code and comments in bcrypt.py and async_client.py.

^{This description was created by for b66a0eb. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 58ee771 in 24 seconds

More details

• Looked at 332 lines of code in 9 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. js/sdk/__tests__/ConversationsIntegrationSuperUser.test.ts:42

• Draft comment:
  Consider checking for an empty string instead of null when verifying the conversation name, as the API might return an empty string for an unset name.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The test for creating a conversation without a name should check for an empty string instead of null, as the API might return an empty string for an unset name.

2. js/sdk/src/v3/clients/conversations.ts:24

• Draft comment:
  Good use of conditional spread operator to include the name in the data object only if it is defined.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The create_conversation method in the ConversationsClient class uses a conditional spread operator to include the name in the data object. This is a good practice to ensure that only defined values are included in the request payload.

3. py/core/database/conversations.py:68

• Draft comment:
  Good use of try-except block to handle exceptions and raise an HTTPException with a detailed error message.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The create_conversation method in the PostgresConversationsHandler class now includes a try-except block to handle exceptions and raise an HTTPException with a detailed error message. This is a good practice for error handling.

4. py/core/main/api/v3/conversations_router.py:90

• Draft comment:
  The create_conversation endpoint now accepts a name parameter, aligning with the new feature of setting a conversation name during creation.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The create_conversation endpoint in the ConversationsRouter class now accepts a name parameter in the request body. This change aligns with the new feature of setting a conversation name during creation.

Workflow ID: wflow_WGnYUhZVNwjSOjAO

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

❌ Changes requested. Incremental review on 0127711 in 44 seconds

More details

• Looked at 414 lines of code in 6 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. js/sdk/src/v3/clients/conversations.ts:86

• Draft comment:
  Consider using PUT or PATCH for updating resources instead of POST for better RESTful API practices.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The update method in conversations.ts uses a POST request to update a conversation, which is unconventional. Typically, PUT or PATCH is used for updates. This might be intentional, but it's worth noting for consistency and clarity.

2. py/core/main/api/v3/conversations_router.py:280

• Draft comment:
  Consider using PUT or PATCH for updating resources instead of POST for better RESTful API practices.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The update_conversation function in conversations_router.py uses a POST request to update a conversation, which is unconventional. Typically, PUT or PATCH is used for updates. This might be intentional, but it's worth noting for consistency and clarity.

Workflow ID: wflow_uopwY5Hah3eHw0cO

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The summary for the update_conversation endpoint is incorrect. It should be 'Update conversation' instead of 'Delete conversation'.

[ellipsis-dev]

❌ Changes requested. Incremental review on ce435a8 in 42 seconds

More details

• Looked at 17 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_FCmgCOoHhZ2ZCNSI

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The cURL example for updating a conversation should use the PUT method instead of POST for clarity and consistency with typical RESTful practices.

[ellipsis-dev]

👍 Looks good to me! Incremental review on b66a0eb in 21 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. py/core/main/api/v3/conversations_router.py:282

• Draft comment:
  Ensure that the CLI code sample reflects the update operation instead of delete.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_bGcELPIUJRnxnLzw

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.