Conversations Updates

[NolanTrem]

Important

Enhance conversations feature with message update functionalities, tests, and remove redundant functions.

• Tests:
  • Add tests for updating message content, metadata, both, handling empty updates, and invalid IDs in ConversationsIntegrationSuperUser.test.ts.
• Functionality:
  • Update updateMessage in conversations.ts to handle optional content and metadata updates.
  • Modify edit_message in conversations.py to support partial updates without changing timestamps.
• Removals:
  • Remove update_message_metadata function from conversations.py and management_service.py.
• Misc:
  • Minor formatting changes in r2rClient.ts.

^{This description was created by for 2af227d. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 70e7c57 in 1 minute and 28 seconds

More details

• Looked at 410 lines of code in 7 files
• Skipped 0 files when reviewing.
• Skipped posting 8 drafted comments based on config settings.

1. js/sdk/__tests__/ConversationsIntegrationSuperUser.test.ts:44

• Draft comment:
  The parameter messageID should be consistent with the backend API, which might expect message_id. Please verify and update accordingly.
• Reason this comment was not posted:
  Comment did not seem useful.

2. js/sdk/__tests__/ConversationsIntegrationSuperUser.test.ts:56

• Draft comment:
  The parameter messageID should be consistent with the backend API, which might expect message_id. Please verify and update accordingly.
• Reason this comment was not posted:
  Marked as duplicate.

3. js/sdk/__tests__/ConversationsIntegrationSuperUser.test.ts:70

• Draft comment:
  The parameter messageID should be consistent with the backend API, which might expect message_id. Please verify and update accordingly.
• Reason this comment was not posted:
  Marked as duplicate.

4. js/sdk/__tests__/ConversationsIntegrationSuperUser.test.ts:83

• Draft comment:
  The parameter messageID should be consistent with the backend API, which might expect message_id. Please verify and update accordingly.
• Reason this comment was not posted:
  Marked as duplicate.

5. js/sdk/__tests__/ConversationsIntegrationSuperUser.test.ts:94

• Draft comment:
  The parameter messageID should be consistent with the backend API, which might expect message_id. Please verify and update accordingly.
• Reason this comment was not posted:
  Marked as duplicate.

6. js/sdk/__tests__/ConversationsIntegrationSuperUser.test.ts:104

• Draft comment:
  The parameter messageID should be consistent with the backend API, which might expect message_id. Please verify and update accordingly.
• Reason this comment was not posted:
  Marked as duplicate.

7. js/sdk/src/v3/clients/conversations.ts:116

• Draft comment:
  The parameter messageID should be consistent with the backend API, which might expect message_id. Please verify and update accordingly.
• Reason this comment was not posted:
  Marked as duplicate.

8. py/core/main/api/v3/conversations_router.py:503

• Draft comment:
  Ensure that the parameter message_id is consistently used across the codebase, especially in test files where messageID is used.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_Z80OQRc0nQ0gmpny

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 2af227d in 11 seconds

More details

• Looked at 12 lines of code in 1 files
• Skipped 1 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. js/sdk/package.json:3

• Draft comment:
  Ensure that the version update to "0.4.7" reflects all the changes made in this PR, including any breaking changes or new features.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The version update in package.json is consistent with the changes made in the PR.

Workflow ID: wflow_zjib2PemDIVAJcvb

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.