Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chunking strategy from test #1715

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 20, 2024

Important

Remove debug print statement in filters.py and comment out unimplemented chunking_strategy in test_ingestion.py.

  • Code Cleanup:
    • Remove debug print statement in apply_filters() in filters.py.
  • Test Adjustments:
    • Comment out chunking_strategy in test_custom_ingestion_config() in test_ingestion.py as it is not implemented.

This description was created by Ellipsis for 4b37dd0. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4b37dd0 in 19 seconds

More details
  • Looked at 27 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/database/filters.py:423
  • Draft comment:
    Remove the print statement used for debugging purposes to clean up the code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The print statement is a debugging artifact and should be removed for cleaner code.

Workflow ID: wflow_i5qdcJ91cJciDteR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 6faec50 into main Dec 20, 2024
14 checks passed
@NolanTrem NolanTrem deleted the Nolan/RemoveChunkingStrategyFromTest branch December 20, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant