-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NaCl Crypto Provider, User API Keys #1713
Conversation
What's up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 69ef78e in 1 minute and 25 seconds
More details
- Looked at
2846
lines of code in41
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. py/core/main/services/auth_service.py:184
- Draft comment:
To prevent email enumeration attacks, consider returning a success message even if the user does not exist. This ensures that the response is consistent regardless of the email's existence. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
2. py/core/base/providers/auth.py:125
- Draft comment:
Ensure that both Bearer token and API key are not provided simultaneously. This is a security risk and should be handled explicitly. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_7AtwZxd2EPPsUPS6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped PR review on 0f1192e because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 95c47a9 in 23 seconds
More details
- Looked at
47
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/tests/integration/test_retrieval_advanced.py:136
- Draft comment:
Commented-out tests should be addressed. If not needed, remove them. If needed, uncomment and fix them. - Reason this comment was not posted:
Confidence changes required:50%
The commented-out tests should be addressed. If they are not needed, they should be removed. If they are needed, they should be uncommented and fixed.
Workflow ID: wflow_ewzUWavtdfZc4bLP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add NaCl crypto provider and implement user API key management, updating authentication, database, and tests.
NaClCryptoProvider
andNaClCryptoConfig
incrypto/nacl.py
.BCryptCryptoProvider
tocrypto/bcrypt.py
.__init__.py
to include new crypto providers.R2RAuthProvider
inauth/r2r_auth.py
to support API key authentication.ApiKey
andApiKeyNoPriv
inmanagement/responses.py
.users_router.py
.PostgresUserHandler
indatabase/users.py
to handle API keys.create_tables()
.test_users.py
.pyproject.toml
to includepynacl
dependency.This description was created by for 95c47a9. It will automatically update as commits are pushed.