Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CLI #1708

Merged
merged 11 commits into from
Dec 27, 2024
Merged

Improved CLI #1708

merged 11 commits into from
Dec 27, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 18, 2024

Improves the CLI

Addresses #1386
Screenshot 2024-12-17 at 5 55 30 PM

Screenshot 2024-12-17 at 5 59 10 PM

Screenshot 2024-12-17 at 6 00 24 PM


Important

Enhances CLI with improved help formatting, error handling, configuration management, and extensive test coverage.

  • CLI Enhancements:
    • Introduces custom_help_formatter in command_group.py for improved help display using rich.
    • Adds CustomGroup and CustomContext classes for enhanced command grouping and context management.
    • Implements error handling improvements across CLI commands, logging errors to stderr.
  • New Features:
    • Adds configuration management commands in commands/config.py for resetting, setting API keys, and viewing configurations.
    • Introduces silent_exit function in command_group.py for graceful command exits.
  • Testing:
    • Adds extensive test coverage for CLI commands in tests/cli/commands/.
    • Utilizes async_invoke helper in tests/cli/async_invoke.py for testing async CLI commands.
  • Miscellaneous:
    • Updates pyproject.toml to include rich as a dependency.
    • Fixes minor issues and refactors code for better readability and maintainability.

This description was created by Ellipsis for 6ac3fb3. It will automatically update as commits are pushed.

@NolanTrem NolanTrem marked this pull request as ready for review December 27, 2024 21:50
@NolanTrem NolanTrem merged commit 36e3188 into main Dec 27, 2024
2 of 3 checks passed
@NolanTrem NolanTrem deleted the Nolan/CLI branch December 27, 2024 21:51
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6ac3fb3 in 1 minute and 21 seconds

More details
  • Looked at 4691 lines of code in 32 files
  • Skipped 1 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_IpbqTBP34gw4xGiA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant