Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include compose.full_with_replicas #1707

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Include compose.full_with_replicas #1707

merged 1 commit into from
Dec 17, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 17, 2024

Important

Add compose.full_with_replicas to pyproject.toml, update version, improve logging, and clean up code.

  • Configuration:
    • Add compose.full_with_replicas to pyproject.toml.
    • Update version to 3.3.16 in pyproject.toml.
  • Logging:
    • Add logger setup in auth_service.py.
    • Replace print statements with logging in auth_service.py.
  • Code Cleanup:
    • Remove unused imports in retrieval_router.py.
    • Remove debug print statements in chunks.py, conversations.py, and retrieval_router.py.
  • Miscellaneous:
    • Minor whitespace changes in r2r-light-py-integration-tests.yml and test_documents.py.

This description was created by Ellipsis for e3cd415. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e3cd415 in 21 seconds

More details
  • Looked at 167 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/tests/integration/test_retrieval_advanced.py:146
  • Draft comment:
    Remove the print statement to clean up test output.
    
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The print statement in the test_agent_clarification_requests function is unnecessary and should be removed to clean up the test output.

Workflow ID: wflow_kkCzkRJ9Ton1UqkR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit b669ec4 into main Dec 17, 2024
1 of 2 checks passed
@NolanTrem NolanTrem deleted the Nolan/IncludeCompose branch December 17, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant