Add Poppler #1706
Merged
Add Poppler #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d44a091 in 12 seconds
More details
- Looked at
35lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/shared/abstractions/document.py:47
- Draft comment:
Ensure that the removal ofWEBP,ICO, andMP4fromDocumentTypedoes not affect other parts of the codebase that might rely on these types. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_PbLam5K5S0z0rxHp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c2cba8e in 8 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/r2r-light-py-integration-tests.yml:50
- Draft comment:
Consider removing 'sudo' from the 'apt-get' commands to ensure compatibility with environments where 'sudo' is not available or necessary. - Reason this comment was not posted:
Confidence changes required:50%
The installation of Poppler is done using 'sudo', which might not be necessary in all environments, especially in containerized or CI environments where the user might already have the necessary permissions. It's better to ensure that the script is compatible with the environment it runs in.
Workflow ID: wflow_Hqv4K6D4VueY6Y2w
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds Poppler installation to CI workflow, removes
WEBP,ICO, andMP4fromDocumentType, and updates version to3.3.15.r2r-light-py-integration-tests.yml.WEBP,ICO, andMP4fromDocumentTypeindocument.py.3.3.14to3.3.15inpyproject.toml.This description was created by
for c2cba8e. It will automatically update as commits are pushed.