up

[emrgnt-cmplxty]

Important

Added update_config endpoint for system configuration updates and enhanced test coverage for collections and user management.

• System Configuration:
  • Added update_config endpoint in system_router.py to allow superusers to update system configuration with deep merge validation.
• Collections SDK:
  • Modified delete, remove_document, and remove_user methods in collections.py to return the full result instead of just the results key.
• Tests:
  • Added new test cases in test_collections.py and test_collections_users_interaction.py to cover edge cases like non-existent collections, invalid data, and unauthorized actions.
  • Removed unused config fixture in test_collections.py.
  • Updated test_users.py with additional validation tests for user updates and deletions.

^{This description was created by for cdffcaf. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to cdffcaf in 1 minute and 31 seconds

More details

• Looked at 997 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. py/core/main/api/v3/system_router.py:324

• Draft comment:
  The method _deep_merge_dicts is used here but is not defined in the provided code. Ensure that this method is implemented correctly elsewhere to avoid runtime errors.
• Reason this comment was not posted:
  Comment did not seem useful.

2. py/sdk/v3/collections.py:138

• Draft comment:
  The return type of the delete method has been changed from a boolean to the raw result. Ensure that this change is intentional and that all consumers of this method are updated accordingly. This comment also applies to remove_document (line 210) and remove_user (line 277).
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_JDfxIdc6E0vooWlA

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The test test_refresh_token is incomplete. It should include assertions to verify the behavior when using an invalid refresh token.