up

[emrgnt-cmplxty]

Important

This pull request removes the logs command and RunType class, updates service creation in R2RBuilder, and modifies routers to use the new service structure.

• Behavior:
  • Remove logs command from system.py, simplifying the CLI interface.
  • Remove RunType class from base.py, run_manager.py, and logger/__init__.py, simplifying run management.
• Services:
  • Update R2RBuilder to use R2RServices for service creation, improving service management.
• Routers:
  • Update ChunksRouter, CollectionsRouter, ConversationsRouter, DocumentsRouter, GraphRouter, IndicesRouter, LogsRouter, PromptsRouter, RetrievalRouterV3, SystemRouter, and UsersRouter to use updated service structure.
• Misc:
  • Remove RunType from LogResponse in responses.py.
  • Remove unused imports and variables across multiple files.

^{This description was created by for 37b1f8e. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 37b1f8e in 1 minute and 50 seconds

More details

• Looked at 2242 lines of code in 25 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. py/core/main/api/v3/system_router.py:302

• Draft comment:
  The run_type_filter parameter is no longer used in the logs method of the management service. Ensure that this change is intentional and that the filtering logic is handled elsewhere if needed.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR removes the RunType enumeration and its usage across multiple files. This change is consistent throughout the codebase, ensuring that the run_type parameter is no longer used in function calls or class initializations. The removal of RunType from the RunInfoLog class and its related imports is also consistent. The PR also updates the manage_run function calls to remove the run_type parameter, which aligns with the removal of RunType. Overall, the changes are consistent and do not introduce any apparent issues.

Workflow ID: wflow_Flt0RvzpscsTQtnW

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.