merge in nolan + main

[emrgnt-cmplxty]

Important

Refactor user registration by introducing a create method, deprecating register, and updating related tests, SDKs, and API routes.

• User Registration Refactor:
  • Introduce create method for user registration in users.py, deprecating register.
  • Update UsersRouter in users_router.py to use create method.
  • Modify AuthService in auth_service.py to support new registration flow.
  • Update AuthMixins and SyncAuthMixins to deprecate register in favor of create.
• Tests and Examples:
  • Update test files like test_users.py, test_collections.py, and others to use create method.
  • Modify example scripts in test_v3_sdk to reflect new user registration method.
• API and SDK Changes:
  • Remove unused LogsResponse and related types in types.ts.
  • Remove logs method from SystemClient in system.ts.
  • Update UsersSDK in users.py to include new create method and deprecate register.
• Miscellaneous:
  • Remove commented-out code and unused imports in various files.
  • Minor logging improvements in clustering/main.py.

^{This description was created by for 9e2d556. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 9e2d556 in 1 minute and 0 seconds

More details

• Looked at 1020 lines of code in 31 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. services/clustering/main.py:8

• Draft comment:
  Consider adding a try-except block around the import of hierarchical_leiden to handle potential import errors gracefully. This will ensure that the application can provide a meaningful error message if the required package is not installed.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code in services/clustering/main.py is mostly clean, but there is a minor issue with the import of hierarchical_leiden. The comment suggests that graspologic[leiden] extras should be installed if needed, but this is not enforced or checked in the code. Additionally, the hierarchical_leiden function is used without any error handling for potential import errors, which could lead to runtime issues if the package is not installed.

2. py/sdk/v2/auth.py:12

• Draft comment:
  Ensure that all deprecated methods are properly marked and consider removing their usage from the codebase if they are no longer needed. This will help in maintaining a clean and updated codebase.
• Reason this comment was not posted:
  Confidence changes required: 30%
  The PR includes a lot of changes, primarily focusing on refactoring and updating the user registration process. The changes seem consistent across the codebase, but there are some areas where deprecated methods are still present. It's important to ensure that all deprecated methods are properly marked and that their usage is minimized or removed where possible.

3. py/sdk/v3/users.py:64

• Draft comment:
  Consider removing the register method or ensuring that its usage is consistent with the new create method to avoid confusion and maintain consistency across the codebase.
• Reason this comment was not posted:
  Confidence changes required: 40%
  The PR includes changes to the user registration process, replacing register with create. However, there are still instances where register is used, which might lead to confusion or inconsistency. It's important to ensure that the transition is complete and consistent across the codebase.

4. py/sdk/v2/sync_auth.py:12

• Draft comment:
  Ensure that all deprecated methods are properly marked and consider removing their usage from the codebase if they are no longer needed. This will help in maintaining a clean and updated codebase.
• Reason this comment was not posted:
  Confidence changes required: 30%
  The PR includes changes to the user registration process, replacing register with create. However, there are still instances where register is used, which might lead to confusion or inconsistency. It's important to ensure that the transition is complete and consistent across the codebase.

Workflow ID: wflow_7pzFq0iOEb6aKGMo

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.