Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup scale settings #1689

Merged
merged 1 commit into from
Dec 12, 2024
Merged

cleanup scale settings #1689

merged 1 commit into from
Dec 12, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Dec 12, 2024

Important

Add --scale option to serve command for scaling R2R service instances and configure Nginx as a reverse proxy.

  • Behavior:
    • Add --scale option to serve command in system.py to specify R2R service instances.
    • Use compose.full_with_replicas.yaml for scaling in Docker Compose setup.
  • Docker Compose:
    • Add compose.full_with_replicas.yaml for handling service scaling.
    • Update get_compose_files() in docker_utils.py to include new compose file.
  • Nginx:
    • Add nginx.conf to configure Nginx as a reverse proxy for R2R service.
  • Functions:
    • Update build_docker_command() in docker_utils.py to handle scale option.

This description was created by Ellipsis for d675b06. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review December 12, 2024 05:10
@emrgnt-cmplxty emrgnt-cmplxty merged commit 6d50084 into main Dec 12, 2024
1 of 19 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d675b06 in 1 minute and 53 seconds

More details
  • Looked at 598 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/cli/utils/docker_utils.py:376
  • Draft comment:
    Remove the print statement used for debugging.
# print("base_command = ", base_command)
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The print statement is likely a leftover from debugging and should be removed for cleaner code.

Workflow ID: wflow_H4n6CZJbpgPHRnwt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant