Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix multi user search #1686

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Dec 11, 2024

Important

Refactor _build_filters in graph.py for improved graph search filtering and bump version to 3.3.14.

  • Behavior:
    • Refactor _build_filters in graph.py to improve filter handling for graph searches.
    • Enhance graph_search in graph.py to use the new _build_filters for constructing WHERE clauses.
  • Misc:
    • Remove unused code in documents_router.py.
    • Bump version in pyproject.toml from 3.3.13 to 3.3.14.

This description was created by Ellipsis for 7887ed5. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review December 11, 2024 04:34
@emrgnt-cmplxty emrgnt-cmplxty merged commit b1936b7 into main Dec 11, 2024
1 of 15 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7887ed5 in 2 minutes and 31 seconds

More details
  • Looked at 371 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. py/core/providers/database/graph.py:2320
  • Draft comment:
    The _build_filters method has been significantly modified. Ensure that all dependent functionalities are tested, as this change could affect various parts of the application.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. py/core/providers/database/graph.py:2250
  • Draft comment:
    The graph_search method now uses the updated _build_filters method. Ensure that the new filtering logic is thoroughly tested to prevent regressions.
  • Reason this comment was not posted:
    Marked as duplicate.
3. py/pyproject.toml:8
  • Draft comment:
    The version has been updated to 3.3.14. Ensure that this version bump accurately reflects the significance of the changes made, especially considering the modifications to the _build_filters method.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The pyproject.toml file has been updated to version 3.3.14. This is a minor version bump, which typically indicates backward-compatible bug fixes or enhancements. However, the changes in the codebase, especially the modifications to the _build_filters method, seem more significant than what a minor version bump would suggest. This discrepancy should be addressed in the versioning strategy.

Workflow ID: wflow_pNv02FTr1B41Q52u


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant