up #1678
up #1678
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 0b073d4 in 2 minutes and 20 seconds
More details
- Looked at
2234lines of code in24files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. py/core/main/api/v3/chunks_router.py:333
- Draft comment:
Theprintstatement here is likely for debugging purposes and should be removed in production code to avoid unnecessary console output. - Reason this comment was not posted:
Marked as duplicate.
2. py/core/main/api/v3/chunks_router.py:335
- Draft comment:
Ensure that changing the filter key fromidtochunk_idis intentional and aligns with the application's logic. This change affects how chunks are identified for deletion. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_VzUAE8zcJ2DSyDqi
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| ) | ||
| print("vector_delete_results = ", vector_delete_results) |
There was a problem hiding this comment.
Remove the print statement used for debugging purposes to avoid unnecessary console output in production.
| @@ -98,7 +98,7 @@ async def _make_streaming_request( | |||
| if line.strip(): # Ignore empty lines | |||
| try: | |||
| yield json.loads(line) | |||
| except json.JSONDecodeError: | |||
| except: # json.JSONDecodeError: | |||
There was a problem hiding this comment.
Catch specific exceptions like json.JSONDecodeError instead of using a bare except to avoid masking other potential issues.
| from r2r import GenerationConfig, Message, R2RClient, R2RException | ||
|
|
||
|
|
||
| def assert_http_error(condition, message): |
There was a problem hiding this comment.
This helper function is duplicated. Consider importing and reusing the existing implementation instead.
- function
assert_http_error(runner_collections.py)
Important
This PR enhances testing for chunks, collections, documents, and retrieval, updates configurations, and fixes core logic issues.
chunks,collections,documents, andretrievalinrunner_chunks.py,runner_collections.py,runner_documents.py, andrunner_retrieval.py..github/actions.r2r_azure.tomlto useopenai/text-embedding-3-smallfor embeddings.pyproject.tomlversion to3.3.9.delete_chunk()inchunks_router.py.retrieval_router.py.transform_chunk_id_to_idlogic inmanagement_service.pyto handle nested filters.multi_search.pyto useazure/gpt-4omodel.graph_searchingraph.pyto improve filter handling.This description was created by
for 0b073d4. It will automatically update as commits are pushed.