Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix owner id references #1673

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix owner id references #1673

merged 1 commit into from
Dec 7, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Dec 7, 2024

Important

Fixes owner ID references in chunks_router.py and documents_router.py, and updates version in pyproject.toml.

  • Behavior:
    • Fixes owner ID reference in delete_chunk() in chunks_router.py.
    • Fixes owner ID reference in delete_document_by_id() in documents_router.py.
  • Misc:
    • Updates version in pyproject.toml from 3.3.6 to 3.3.7.

This description was created by Ellipsis for 53efcb3. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review December 7, 2024 01:17
@emrgnt-cmplxty emrgnt-cmplxty merged commit ebac5a2 into main Dec 7, 2024
1 of 13 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 53efcb3 in 15 seconds

More details
  • Looked at 41 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/core/main/api/v3/chunks_router.py:334
  • Draft comment:
    The change from id to owner_id is consistent with the intent to fix owner id references. Ensure that the database schema and any related logic also reflect this change.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the field from 'id' to 'owner_id' in two places, which is consistent with the intent to fix owner id references.
2. py/core/main/api/v3/documents_router.py:1106
  • Draft comment:
    The change from id to owner_id is consistent with the intent to fix owner id references. Ensure that the database schema and any related logic also reflect this change.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the field from 'id' to 'owner_id' in two places, which is consistent with the intent to fix owner id references.

Workflow ID: wflow_W4xZ5VY3yaYHoEDG


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant