fix retrieval

[emrgnt-cmplxty]

Important

Add "custom" parameter to search function and handle empty search results in retrieval.py and search.py.

• Behavior:
  • Add "custom" parameter to client.retrieval.search() in retrieval.py to specify search type.
  • Handle empty graph_search_results and web_search_results in as_dict() in search.py by returning empty lists.
• Versioning:
  • Increment version from 3.3.4 to 3.3.5 in pyproject.toml.

^{This description was created by for e85378e. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to e85378e in 10 seconds

More details

• Looked at 44 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. py/cli/commands/retrieval.py:84

• Draft comment:
  Consider using the SearchMode enum instead of the hardcoded string "custom" for better maintainability and to avoid potential errors from typos.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The change in retrieval.py adds a hardcoded string "custom" to the search function call. This might be intended to specify a search mode, but it should be verified if this is the correct approach. The SearchSettings class has a method get_default that uses modes like "basic", "advanced", and "custom". It would be better to use an enum or a constant for these modes to avoid hardcoding strings.

Workflow ID: wflow_t9TrlaagqyrjTwsZ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.