fix provider defaults issue #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to fa302bf in 1 minute and 24 seconds
More details
- Looked at
210lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/core/main/api/v3/documents_router.py:278
- Draft comment:
Remove theprintstatement used for debugging purposes to clean up the production code. - Reason this comment was not posted:
Confidence changes required:50%
Theprintstatement is likely used for debugging and should be removed in production code.
Workflow ID: wflow_xxH0nV9bA1hN6gPN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| return cls(app=app, parser_overrides={"pdf": "zerox"}) | ||
| else: | ||
| return cls(app=app) | ||
|
|
||
| @classmethod | ||
| def get_default(cls, mode: str, app) -> "IngestionConfig": |
There was a problem hiding this comment.
The get_default method is defined twice in the IngestionConfig class. Consider removing one of the definitions to avoid redundancy and potential confusion.
| @@ -59,6 +122,36 @@ | |||
| return cls(app=app) | |||
|
|
|||
|
|
|||
| @classmethod | |||
| def set_default(cls, **kwargs): | |||
There was a problem hiding this comment.
The set_default method is defined twice in the IngestionConfig class. Consider removing one of the definitions to avoid redundancy and potential confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improved
IngestionConfigdefault handling with dynamic methods and added logging for effective configuration indocuments_router.py._defaultsclass variable inIngestionConfigto store default values.set_default()andget_default()methods to dynamically manage default values.IngestionConfigto usedefault_factoryfor defaults.create_document()indocuments_router.pyto logeffective_ingestion_config.pyproject.tomlfrom3.3.3to3.3.4.This description was created by
for fa302bf. It will automatically update as commits are pushed.