Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev minor #1665

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Dev minor #1665

merged 5 commits into from
Dec 6, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Dec 6, 2024

Important

Enhances document ingestion, retrieval, and logging with new modes, configurations, and real-time log streaming.

  • Ingestion:
    • Introduced IngestionMode enum with modes hi-res, fast, and custom in document.py and ingestion.py.
    • Added IngestionConfig class with default configurations for different modes in document.py.
    • Updated DocumentsRouter to handle new ingestion modes and configurations.
  • Retrieval:
    • Added SearchMode enum with modes basic, advanced, and custom in search.py.
    • Enhanced RetrievalRouterV3 to support new search modes and settings.
    • Updated RetrievalService to handle search and RAG operations with new settings.
  • Logging:
    • Added LogsRouter and log_viewer.html for real-time log streaming and viewing.
    • Introduced configure_logging() in logging_config.py for enhanced logging setup.
  • SDK:
    • Updated DocumentsSDK and RetrievalSDK to support new ingestion and search configurations.
  • Miscellaneous:
    • Updated pyproject.toml to include colorlog for colored logging output.
    • Refactored various classes and functions for consistency and improved functionality.

This description was created by Ellipsis for f4c39c1. It will automatically update as commits are pushed.

emrgnt-cmplxty and others added 4 commits December 5, 2024 12:05
* add web search to rag agent

* add web search to rag agent
* Fix agent bug, remove alias

* Allow ws on logs
* up

* add ingestion settings too

* up

* up

* up
@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review December 6, 2024 05:19
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 63a7917 in 1 minute and 55 seconds

More details
  • Looked at 2756 lines of code in 38 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/shared/utils/base_utils.py:102
  • Draft comment:
    The format_search_results_for_stream function contains commented-out code and incomplete logic for handling KG search results. Consider cleaning up the function by removing commented-out code and ensuring all search result types are handled correctly.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The format_search_results_for_stream function in py/shared/utils/base_utils.py is responsible for formatting search results for streaming. However, the function currently has commented-out code and incomplete logic for handling KG search results. This can lead to confusion and potential errors if the function is used in its current state. It's important to clean up the function by removing commented-out code and ensuring that all types of search results are handled correctly.

Workflow ID: wflow_21lGX2YIDkanIHK3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on f4c39c1 in 25 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_gOc4BWKTXNd87Xra


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty merged commit 1d5f1eb into main Dec 6, 2024
7 of 25 checks passed
@NolanTrem NolanTrem deleted the dev-minor branch December 6, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants