-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev minor #1665
Dev minor #1665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 63a7917 in 1 minute and 55 seconds
More details
- Looked at
2756
lines of code in38
files - Skipped
2
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/shared/utils/base_utils.py:102
- Draft comment:
Theformat_search_results_for_stream
function contains commented-out code and incomplete logic for handling KG search results. Consider cleaning up the function by removing commented-out code and ensuring all search result types are handled correctly. - Reason this comment was not posted:
Confidence changes required:50%
Theformat_search_results_for_stream
function inpy/shared/utils/base_utils.py
is responsible for formatting search results for streaming. However, the function currently has commented-out code and incomplete logic for handling KG search results. This can lead to confusion and potential errors if the function is used in its current state. It's important to clean up the function by removing commented-out code and ensuring that all types of search results are handled correctly.
Workflow ID: wflow_21lGX2YIDkanIHK3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on f4c39c1 in 25 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_gOc4BWKTXNd87Xra
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Enhances document ingestion, retrieval, and logging with new modes, configurations, and real-time log streaming.
IngestionMode
enum with modeshi-res
,fast
, andcustom
indocument.py
andingestion.py
.IngestionConfig
class with default configurations for different modes indocument.py
.DocumentsRouter
to handle new ingestion modes and configurations.SearchMode
enum with modesbasic
,advanced
, andcustom
insearch.py
.RetrievalRouterV3
to support new search modes and settings.RetrievalService
to handle search and RAG operations with new settings.LogsRouter
andlog_viewer.html
for real-time log streaming and viewing.configure_logging()
inlogging_config.py
for enhanced logging setup.DocumentsSDK
andRetrievalSDK
to support new ingestion and search configurations.pyproject.toml
to includecolorlog
for colored logging output.This description was created by for f4c39c1. It will automatically update as commits are pushed.