Update arraymancer dependency, remove len
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the previous commit of checking for the error pragma the original tests did now not pass. We were generating code `Tensor + Scalar` in the previous version for this. But that was never actually intended. Technically it was simply allowed and 'correct' given our logic and available tools in arraymancer.
On versions other than devel, `max` here is being bound to the new `max` that takes `varargs[Tensor]` and produces `Tensor`, breaking the formula!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes our custom
lendue to the arraymancer addition of it.And a minor improvement to the formula logic, which now ignores any procedures, which use the
{.error.}pragma for potential type matching.