Add ReverseDiff weak dep #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with backwards compatibility. Comes from SciMLSensitivity.jl back compat split.
oscardssmith
approved these changes
Feb 6, 2023
chriselrod
reviewed
Feb 6, 2023
src/RecursiveArrayTools.jl
Outdated
| @@ -42,6 +42,13 @@ function ChainRulesCore.rrule(T::Type{<:GPUArraysCore.AbstractGPUArray}, | |||
| T(xs), ȳ -> (NoTangent(), ȳ) | |||
| end | |||
|
|
|||
| import Requires | |||
| function __init__() | |||
| @static if !isdefined(Base, :get_extension) | |||
There was a problem hiding this comment.
Could move this check outside the function to avoid loading it.
| a::AbstractArray{T2, N}) where { | ||
| T <: | ||
| Tracker.TrackedArray, | ||
| T2 <: |
There was a problem hiding this comment.
Tracker.TrackedArray probably isn't in scope?
ChrisRackauckas
added a commit
to SciML/SciMLSensitivity.jl
that referenced
this pull request
Feb 6, 2023
Requires: * SciML/PreallocationTools.jl#58 * SciML/RecursiveArrayTools.jl#247 * SciML/DiffEqBase.jl#871 Moving all of those to their rightful places instead of pirating now that a weak dependency system exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with backwards compatibility. Comes from SciMLSensitivity.jl back compat split.