Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #921

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix CI #921

wants to merge 6 commits into from
+35 −24

Conversation

sathvikbhagavan
Copy link
Member

Noticed CI was broken on master. Attempting to fix it.

@sathvikbhagavan sathvikbhagavan marked this pull request as draft February 3, 2025 11:08
@sathvikbhagavan sathvikbhagavan force-pushed the sb/fix_CI branch 2 times, most recently from 20b2252 to 01a94af Compare February 3, 2025 15:16
@sathvikbhagavan sathvikbhagavan marked this pull request as ready for review February 23, 2025 22:02
@sathvikbhagavan
Copy link
Member Author

@ChrisRackauckas, this fixes most of CI. There is one issue in BPINN which I am not familiar and second there is a piracy in https://github.com/SciML/NeuralPDE.jl/blob/master/src/pino_ode_solve.jl#L291 where sol(t::AbstractArray) is defined as t can be a higher order array for PINO. Is there a way to remove the piracy or should I change PINO such that it only takes time points as a vector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sathvikbhagavan