Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run initialization on ODEs with superset initial conditions #2850

Closed
wants to merge 7 commits into from
Closed

Run initialization on ODEs with superset initial conditions #2850

wants to merge 7 commits into from

Commits on Sep 6, 2024

  1. Run initialization on ODEs with superset initial conditions 

    InitializationProblem is not always built, however it missed a case. If you have an ODE and you define all of the initial conditions, then it does not need an initialization problem. But, if you simplify down to an ODE and give initial conditions for all of the original variables, including some simplified out, then you have defined initial conditions on some observed quantities and that needs to be accounted for by an initialization process.

This fixes #2619
    @ChrisRackauckas
    ChrisRackauckas committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d68b70e View commit details
    Browse the repository at this point in the history

  2. format

    @ChrisRackauckas
    ChrisRackauckas committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0995efc View commit details
    Browse the repository at this point in the history

  3. Update src/systems/diffeqs/abstractodesystem.jl 

    Co-authored-by: Aayush Sabharwal <aayush.sabharwal@gmail.com>
    @ChrisRackauckas @AayushSabharwal
    ChrisRackauckas and AayushSabharwal committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    21249bd View commit details
    Browse the repository at this point in the history

  4. Update src/systems/diffeqs/abstractodesystem.jl 

    Co-authored-by: Aayush Sabharwal <aayush.sabharwal@gmail.com>
    @ChrisRackauckas @AayushSabharwal
    ChrisRackauckas and AayushSabharwal committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3f244a2 View commit details
    Browse the repository at this point in the history

  5. Update src/systems/diffeqs/abstractodesystem.jl

    @ChrisRackauckas
    ChrisRackauckas authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5561017 View commit details
    Browse the repository at this point in the history

  6. Depwarn fix

    @ChrisRackauckas
    ChrisRackauckas committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2901f29 View commit details
    Browse the repository at this point in the history

  7. Update test/initializationsystem.jl 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @ChrisRackauckas @github-actions
    ChrisRackauckas and github-actions[bot] authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8206ac5 View commit details
    Browse the repository at this point in the history