Fix incorrect substitution for finite domain transformation #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch substitution bug
|
Hi, thanks for the pr! I made that mistake and made a fix for it in #241, but I agree we should patch this ASAP since that pr is more ambitious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
In the infinity handling code, the branch that transforms non-infinite dimensions made an incorrect substitution leading to plainly incorrect results. This was not caught by tests because this branch was only tested with a constant function, which is only sensitive to the correctness of the jacobian, not the substituted value.
This PR modifies tests to use a quadratic instead of constant, adds tests for mixed infinite-finite multivariate problems (which I suppose is the reason this branch exists at all), and finally fixes the substitution such that the tests pass.