Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expv error estimate: hermitian only #165

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

daviehh
Copy link
Contributor

@daviehh daviehh commented Feb 14, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Currently, krylov_phiv_error_estimate.jl only implements the Lanczos algorithm for Hermitian matrix, which gives a tridiagonal H to use with the expT! functiopns's stegr call

LAPACK.stegr!(α, β, cache.sw)

This PR passes on the ishermitian argument and errors if false.

Fixes #160

--
whitespace changes is with JuliaFormatter's sciml style.

@ChrisRackauckas ChrisRackauckas merged commit 1a02e54 into SciML:master Feb 14, 2024
18 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mode=:error_estimate gives wrong results for long times
2 participants