Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thread keyword to calculate_residuals! #711

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Oct 22, 2021

See SciML/OrdinaryDiffEq.jl#1508. This enables threaded parallelism via FastBroadcast.jl and Polyester.jl in calculate_residuals!. This is a necessary first step to enable the same threaded parallelism in explicit RK methods in OrdinaryDiffEq.jl, see SciML/OrdinaryDiffEq.jl#1423.

@ranocha ranocha marked this pull request as ready for review October 22, 2021 10:00
@ranocha
Copy link
Member Author

ranocha commented Oct 22, 2021

The error in the tests of this PR looks exactly like the one on master - it's unrelated to this PR, I think?

@ChrisRackauckas
Copy link
Member

yeah unrelated. I'll have to take a look later.

@ChrisRackauckas ChrisRackauckas merged commit 2d68e2b into SciML:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants