fix: fix usage of ReverseDiff in parameters #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test. |
Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
| if SciMLStructures.isscimlstructure(p) | ||
| _p = SciMLStructures.canonicalize(SciMLStructures.Tunable(), p)[1] | ||
| if _p != p | ||
| return promote_u0(u0, _p, t0) |
There was a problem hiding this comment.
won't you need to restructure or replace! with this?
There was a problem hiding this comment.
No, we're not changing p. canonicalize is only used to get the tunables array, since that's what we want to dispatch off of.
AayushSabharwal
force-pushed
the
as/reversediff
branch
from
aa37f83
to
556aa65
Compare
|
Tests failed |
AayushSabharwal
force-pushed
the
as/reversediff
branch
from
556aa65
to
4e60a87
Compare
|
Can you also hunt down https://github.com/SciML/DiffEqBase.jl/actions/runs/10699836596/job/29662267061?pr=1078#step:6:946 ? |
|
That is SciML/SciMLBase.jl#780 which hasn't been tagged yet, so isn't used by CI. It's why I opened that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.