-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix usage of ReverseDiff in parameters #1078
Conversation
Needs a test. |
Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
if SciMLStructures.isscimlstructure(p) | ||
_p = SciMLStructures.canonicalize(SciMLStructures.Tunable(), p)[1] | ||
if _p != p | ||
return promote_u0(u0, _p, t0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't you need to restructure or replace! with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we're not changing p
. canonicalize
is only used to get the tunables array, since that's what we want to dispatch off of.
aa37f83
to
556aa65
Compare
Tests failed |
556aa65
to
4e60a87
Compare
Can you also hunt down https://github.com/SciML/DiffEqBase.jl/actions/runs/10699836596/job/29662267061?pr=1078#step:6:946 ? |
That is SciML/SciMLBase.jl#780 which hasn't been tagged yet, so isn't used by CI. It's why I opened that PR |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.