Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bias -> use_bias #91

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Upgrade bias -> use_bias #91

merged 1 commit into from
Aug 1, 2023

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

Copy link

@ai-maintainer ai-maintainer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-Maintainer Review for PR - Upgrade bias -> use_bias

Title and Description 👍

Title is clear but description is missing
The title of the pull request is clear and concise, effectively communicating the purpose of the changes. However, the description is missing. It would be beneficial to include a brief explanation in the description that provides more context or reasoning behind the change.

Scope of Changes 👍

Changes are narrowly focused
The changes in the pull request are narrowly focused. The modifications made to specific lines of code in multiple files are all related to replacing the term "bias" with "use_bias". This indicates that the author's intention is to address a specific issue or make a specific improvement related to the use of bias in the codebase.

Testing ⚠️

No information about testing provided
The description of the pull request does not provide any information about how the author tested the changes. It would be beneficial for the author to include details about the testing process they followed to ensure the correctness and effectiveness of the modifications. This could include information about the test cases used, the expected outcomes, and any additional steps taken to validate the changes.

Code Changes 👍

Code changes are appropriate
The code changes are appropriate and align with the stated purpose of the pull request. The term "bias" has been replaced with "use_bias" in the relevant sections of the codebase.

Suggested Changes

Please provide a description for the pull request that includes the reasoning behind the change from "bias" to "use_bias" and details about how you tested the changes. This will help reviewers understand the context and verify the effectiveness of the changes.

Reviewed with AI Maintainer

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #91 (5ffb5c1) into main (2e9c500) will decrease coverage by 5.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   88.65%   83.40%   -5.26%     
==========================================
  Files           9        8       -1     
  Lines         238      235       -3     
==========================================
- Hits          211      196      -15     
- Misses         27       39      +12     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas
Copy link
Member Author

@avik-pal can you fix the doc build citations stuff? Just trying to get everything green again. https://github.com/SciML/DeepEquilibriumNetworks.jl/actions/runs/5723384936/job/15507892741?pr=91#step:5:14

@ChrisRackauckas ChrisRackauckas merged commit 3ffec08 into main Aug 1, 2023
9 of 11 checks passed
@ChrisRackauckas ChrisRackauckas deleted the lux_upgrade branch August 1, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant