Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update tests workflow to use centralised reusable workflow and auto-suggest format changes #159

Merged
merged 8 commits into from
Sep 6, 2024
Merged

ci: update tests workflow to use centralised reusable workflow and auto-suggest format changes #159

merged 8 commits into from
Sep 6, 2024

Conversation

thazhemadam
Copy link
Member

Follow up to #153.

@thazhemadam thazhemadam changed the title ci: update tests workflow to use centralised reusable workflow and remove FormatPR ci: update tests workflow to use centralised reusable workflow and auto-suggest format changes Jul 29, 2024
@avik-pal
Copy link
Member

Are the failures stemming from __solve(::NonlinearProblem, ::<SimpleNonlinearSolveAlg>) being removed in favor of ImmutableNonlinearProblem?

@ChrisRackauckas
Copy link
Member

The current failure is just the depwarn JuliaGPU/GPUCompiler.jl#616 ?

@ChrisRackauckas
Copy link
Member

The depwarns are from an old version, @avik-pal do you know why the old version is there?

@avik-pal
Copy link
Member

avik-pal commented Aug 19, 2024 •
edited
Loading

https://github.com/EnzymeAD/Enzyme.jl/blob/e1edaf7482dee3be5bcf35afb7527cea808a1f07/Project.toml#L39 doesn't support the latest GPUCompiler yet. I think LLVM.jl 8 was the blocking issue there maleadt/LLVM.jl#435 (cc @wsmoses)

@avik-pal avik-pal mentioned this pull request Aug 21, 2024
Open
@avik-pal avik-pal closed this Aug 26, 2024
@avik-pal avik-pal reopened this Aug 26, 2024
@avik-pal
Copy link
Member

(NOTE TO SELF) LuxTestUtils (

DeepEquilibriumNetworks.jl/Project.toml

Line 47 in de2c730

LuxTestUtils = "0.1.15"
) needs to be updated to the latest version

@ChrisRackauckas
Copy link
Member

@wsmoses I thought you said v0.12.33 should do it? https://github.com/SciML/DeepEquilibriumNetworks.jl/actions/runs/10562146339/job/29259477769?pr=159#step:6:71

@wsmoses
Copy link

wsmoses commented Aug 27, 2024

I said that bumped the gpucompiler compat, the deprecation from llvm.jl can’t be fixed til we drop old Julia’s with the new LTS (since the function is indicative of Julia version config for older Julia)

@ChrisRackauckas
Copy link
Member

@avik-pal you got this as part of your other update?

@avik-pal
Copy link
Member

avik-pal commented Sep 2, 2024

yeah, I will merge that and then figure out the failure here.

@thazhemadam @avik-pal
ci: update tests workflow to use centralised reusable workflow
6c5e5e3
@thazhemadam @avik-pal
ci: remove FormatCheck workflow
f144deb 
Remove the `FormatCheck` workflow, since code in the repository should
always be compliant with the SciML style, thus eliminating the need for
automated formatting PRs.
@thazhemadam @avik-pal
ci(format-check): automatically comment formatting suggestions on PRs
528b4fd
@avik-pal
Copy link
Member

avik-pal commented Sep 3, 2024 •
edited
Loading

Once https://github.com/SciML/DeepEquilibriumNetworks.jl/actions/runs/10675542556/job/29587688915?pr=159#step:6:950 is fixed the tests will pass. Coming from Enzyme + GPUCompiler which will get fixed as mentioned in #159 (comment)

@avik-pal avik-pal merged commit ec41b75 into main Sep 6, 2024
9 checks passed
@avik-pal avik-pal deleted the at/use-reusable-workflows branch September 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avik-pal avik-pal avik-pal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thazhemadam @avik-pal @ChrisRackauckas @wsmoses