Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using SimpleGMRES for the backward pass #139

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 21, 2023

@avik-pal avik-pal force-pushed the ap/defaults branch 3 times, most recently from 72ac6d1 to 4472676 Compare December 21, 2023 18:44
@avik-pal avik-pal changed the title Default to using SimpleGMRES for the backward pass [WIP] Default to using SimpleGMRES for the backward pass Dec 21, 2023
@avik-pal avik-pal force-pushed the ap/defaults branch 3 times, most recently from f5146a9 to f1fe248 Compare December 22, 2023 16:42
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (444cd3c) 93.85% compared to head (64f84a1) 93.95%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   93.85%   93.95%   +0.10%     
==========================================
  Files           5        5              
  Lines         179      182       +3     
==========================================
+ Hits          168      171       +3     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal changed the title [WIP] Default to using SimpleGMRES for the backward pass Default to using SimpleGMRES for the backward pass Dec 22, 2023
@avik-pal avik-pal merged commit f055519 into main Dec 22, 2023
11 checks passed
@avik-pal avik-pal deleted the ap/defaults branch December 22, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant