Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AutoGTPSA backend #78

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add AutoGTPSA backend #78

merged 2 commits into from
Sep 17, 2024

Conversation

mattsignorelli
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This PR adds the AutoGTPSA type for choosing the GTPSA.jl backend. Bindings to DifferentiationInterface.jl are ready here

@mattsignorelli mattsignorelli mentioned this pull request Aug 8, 2024
Draft
@gdalle
Copy link
Collaborator

gdalle commented Aug 8, 2024 •
edited
Loading

Thank you for this addition! Let me just review gdalle/DifferentiationInterface.jl#329 first to make sure we're not missing anything in the backend object

@gdalle gdalle self-assigned this Aug 8, 2024
@gdalle gdalle self-requested a review August 8, 2024 14:57
gdalle
gdalle approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@gdalle gdalle mentioned this pull request Sep 17, 2024
Merged
@gdalle gdalle merged commit c4b9a4c into SciML:main Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdalle gdalle gdalle approved these changes

Assignees

@gdalle gdalle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsignorelli @gdalle