Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging unit tests in a systematic-like manner #203

Closed
23 tasks done
mxochicale opened this issue Feb 1, 2023 · 15 comments
Closed
23 tasks done

Debugging unit tests in a systematic-like manner #203

mxochicale opened this issue Feb 1, 2023 · 15 comments
Assignees
@mxochicale

Comments

@mxochicale
Copy link
Contributor

mxochicale commented Feb 1, 2023 •
edited
Loading

I am raising this ticket to easily track local and remote unit tests for #187.

Context

Pyside6 migration seems to be working fine for linux, windows and mac (#187), however there are few tests that are failing. So, this issue will debug unit tests in a systematic-like manner. The following list shows local and remote tests showing (:heavy_check_mark:) for passing test, (:cloud:) for passing remote unit tests, (:penguin: :computer:) for local ones.

  • [01-items] tests/camera/test_liver_overlay.py
    ✔️ ☁️ 🐧 💻 test_overlay_liver_points(setup_vtk_overlay_window): (previously failing in remote ubuntu-latest ❎ )
  • [05-items] tests/camera/test_vtk_camera_model.py
    ✔️ ☁️ 🐧 💻 test_camera_projection(setup_vtk_overlay_window):
  • [12 items] tests/models/test_surface_model_loader.py :
    ✔️ ☁️ 🐧 💻 test_surface_model_loader_2_in_assembly_on_its_own (previously failing in mac-latest,3.9: ❎ )
  • [09-items] tests/models/test_voxelise.py
  • [02-items] tests/models/test_vtk_cylinder_model.py
    ✔️ ☁️ 🐧 💻 test_cylinder_model(setup_vtk_overlay_window)
  • [02-items] tests/models/test_vtk_image_model.py
    ✔️ ☁️ 🐧 💻 test_valid_vtk_image_actor(): (refactored)
    ✔️ ☁️ 🐧 💻 test_image_model_overlay(vtk_overlay_with_gradient_image): (failed in remote mac-latest ❎ refactored vtk pipeline )
  • [15-items] tests/models/test_vtk_point_model.py
  • [07-items] tests/models/test_vtk_sphere_model.py
    ✔️ ☁️ 🐧 💻 test_sphere_model_3_points(setup_vtk_overlay_window):
  • [08-items] tests/models/test_vtk_surface_model_directory_loader.py
  • [37-items] tests/models/test_vtk_surface_model.py
    ✔️ ☁️ 🐧 💻 test_set_texture_regression(vtk_overlay_with_gradient_image) (was failing ❎)
    ✔️ ☁️ 🐧 💻 test_valid_set_texture_with_png_format(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_valid_set_texture_with_jpg_format(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_flat_shaded_on_coloured_background(setup_vtk_overlay_window):
    ✔️ ☁️ 🐧 💻 test_valid_set_texture_with_jpeg_format(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_valid_unset_texture_when_called_with_none(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_set_texture_regression(vtk_overlay_with_gradient_image):
  • [02-items] tests/models/test_vtk_unstructured_grid.py
  • [06-items] tests/text/test_corner_annotaiton.py
  • [01-items] tests/text/test_large_centred_text.py
    ✔️ ☁️ 🐧 💻 test_position_correct(setup_vtk_overlay_window):
  • [07-items] tests/text/test_vtk_text.py
    ✔️ ☁️ 🐧 💻 test_window_resize (solved for linux and SKIPPED for others OS due to vtk pipeline ❎ 🐧 💻 )
  • [06-items] tests/utils/test_matrix_utills.py
  • [03-items] tests/utils/test_polydata_utils.py
  • [14-items] tests/utils/test_projection_utils.py
  • [01-items] tests/widgets/test_interlaced_stereo_window.py
    ✔️ ☁️ 🐧 💻 test_stereo_overlay_window (partially solve in linux but SKIPPED due to vtk pipelines in all OSs)
  • [02-items] tests/widgets/test_lus_simulator.py
    ✔️ ☁️ 🐧 💻 test_basic_rendering_generator (partially solve in linux but SKIPPED due to vtk pipelines in all OSs ❎ 🐧 💻 )
    ✔️ ☁️ 🐧 💻 test_matrices_rendering_generator (partially solve in linux but SKIPPED due to vtk pipelines in all OSs ❎ 🐧 💻 )
  • [05-items] tests/widgets/test_rendering_generator.py
    ✔️ ☁️ 🐧 💻 test_basic_rendering_generator() (failed due to vtk pipeline inVTKRenderingGenerator ❎ 🐧 💻)
    ✔️ ☁️ 🐧 💻 test_basic_rendering_generator_zbuffer() (failed due to vtk pipeline inVTKRenderingGenerator ❎ 🐧 💻)
    ✔️ ☁️ 🐧 💻 test_mask_generator() (failed due to vtk pipeline inVTKRenderingGenerator ❎ 🐧 💻)
    ✔️ ☁️ 🐧 💻 test_mask_generator_w_all_shading() (failed due to vtk pipeline inVTKRenderingGenerator ❎ 🐧 💻)
    ✔️ ☁️ 🐧 💻 test_mask_generator_w_some_shading() (failed due to vtk pipeline inVTKRenderingGenerator ❎ 🐧 💻)
  • [12-items] tests/widgets/test_vtk_overlay_window.py
    ✔️ ☁️ 🐧 💻 test_vtk_render_window_settings(setup_vtk_overlay_window):
    ✔️ ☁️ 🐧 💻 test_vtk_render_window_settings_no_init(setup_vtk_overlay_window_no_init):
    ✔️ ☁️ 🐧 💻 test_vtk_foreground_render_settings(setup_vtk_overlay_window):
    ✔️ ☁️ 🐧 💻 test_vtk_background_render_settings(setup_vtk_overlay_window):
    ✔️ ☁️ 🐧 💻 test_image_importer(setup_vtk_overlay_window):
    ✔️ ☁️ 🐧 💻 test_frame_pixels(setup_vtk_overlay_window):
    ✔️ ☁️ 🐧 💻 test_basic_cone_overlay(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_point_set_overlay(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_surface_model_overlay(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_add_model_to_background_renderer_raises_error(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_add_models_to_foreground_renderer(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_add_models_to_overlay_renderer(vtk_overlay_with_gradient_image):
  • [02-items] tests/widgets/test_vtk_overlay_window_with_outlines.py
    ✔️ ☁️ 🐧 💻 test_surface_without_outline(vtk_overlay_with_gradient_image):
    ✔️ ☁️ 🐧 💻 test_surface_outline_overlay(vtk_overlay_with_gradient_image):
  • [02-items] tests/widgets/test_vtk_reslice.py
    ✔️ ☁️ 🐧 💻 test_slice_viewer(qtbot)
    ✔️ ☁️ 🐧 💻 test_mouse_scroll_slice_viewer(qtbot)
@mxochicale mxochicale self-assigned this Feb 1, 2023
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
✔️ local unit tests/models/test_surface_model_loader.py; (#203, #187)
27ad53c
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
🔴 test_surface_model_loader_2_in_assembly_on_its_own > tests/models/t…
0bd5f2e 
…est_surface_model_loader.py; (#203, #187)
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
remove unnecessary parenthesis vtk_camera_model.py (#203, #187)
3432267
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
adds further packages to ci.yml pylint (#203, #187)
571bcdb
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
updates pylintc overgeneral-exceptions=builtins.Exception (#203, #187)
4a7cdeb
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
adds version of pylint>=2.16.0 in requirements-dev.txt (#203, #187)
378396a
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.0 in requirements-dev.txt (#203, #187)
1a7c225
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.1 in requirements-dev.txt (#203, #187)
87bb969
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.2 in requirements-dev.txt (#203, #187)
4e81e36
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.3 in requirements-dev.txt (#203, #187)
95e49fb
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.4 in requirements-dev.txt (#203, #187)
0c0ef00
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.5 in requirements-dev.txt (#203, #187)
8f41e56
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.6 in requirements-dev.txt (#203, #187)
1aba797
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.7 in requirements-dev.txt (#203, #187)
f4e78a9
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.8 in requirements-dev.txt (#203, #187)
e8d0ad0
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.9 in requirements-dev.txt (#203, #187)
88ca102
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
pylint>=2.15.10 in requirements-dev.txt (#203, #187)
68ae9c0
@mxochicale
Copy link
Contributor Author

🎉 pylint>=2.15.10 works well for different OS (Ubuntu, mac, windows) and py versions (py37, p38): https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4066002342/jobs/7001476954.
Note. You might be careful with the selection of pylint version https://github.com/PyCQA/pylint/tags as migth brake your cis (for this one I tried 2.15.0, 2.15.1, 2.15.2,2.15.3,2.15.4,2.15.5,2.15.6,2.15.7,2.15.8, and 2.16.0)

mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
ci deploy to ubuntu-22.04 with py37; (#203, #187)
62fc332
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
ci deploy to ubuntu-22.04 with py36; (#203, #187)
e8b41fd
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
ci deploy to ubuntu-18.04 with py37; (#203, #187)
ab9019a
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
ci deploy to ubuntu-20.04 with py37; (#203, #187)
0eceb3a
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
ci deploy to ubuntu-18.04 with py36; (#203, #187)
15742e2
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
ci deploy to ubuntu-18.04 with py36; bringing back the passed yml (#203…
f1f0f96 
…, #187)
@mxochicale
Copy link
Contributor Author

Not sure what's happening with the github action but changing ci.yml for its deploy versions brakes some tests:
0eceb3a ci deploy to ubuntu-20.04 with py37; (#203, #187)
ab9019a ci deploy to ubuntu-18.04 with py37; (#203, #187)
e8b41fd ci deploy to ubuntu-22.04 with py36; (#203, #187)
62fc332 ci deploy to ubuntu-22.04 with py37; (#203, #187)

so I returned to the passed one:
f1f0f96 (HEAD -> 187-pyside6, origin/187-pyside6) ci deploy to ubuntu-18.04 with py36; bringing back the passed yml (#203, #187)

mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
ci deploy to ubuntu-20.04 with py37; pylint>=2.16.0; (#203, #187)
944ef7a
mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
✔️ local unit tests/models/test_voxelise.py; (#203 #187)
76a5d82
@mxochicale
Copy link
Contributor Author

local test ⚠️ in tests/models/test_voxelise.py

tests/models/test_voxelise.py::test_entire_workflow 2023-02-01 16:42:08.322 (  27.661s) [        51DB4740]       vtkXMLWriter.cxx:649    ERR| vtkXMLPolyDataWriter (0x3a52190): Error opening output file "tests/data/output/voxelise/deformed_no_saved_grid.vtp"
2023-02-01 16:42:08.322 (  27.661s) [        51DB4740]       vtkXMLWriter.cxx:651    ERR| vtkXMLPolyDataWriter (0x3a52190): Error code "No such file or directory"
2023-02-01 16:42:08.322 (  27.661s) [        51DB4740]       vtkExecutive.cxx:752    ERR| vtkCompositeDataPipeline (0x3abd230): Algorithm vtkXMLPolyDataWriter(0x3a52190) returned failure for request: vtkInformation (0x3a2d870)
  Debug: Off
  Modified Time: 842584
  Reference Count: 1
  Registered Events: (none)
  Request: REQUEST_DATA
  FROM_OUTPUT_PORT: -1
  ALGORITHM_AFTER_FORWARD: 1
  FORWARD_DIRECTION: 0


PASSED

================================================================================================ warnings summary =================================================================================================
tests/models/test_voxelise.py::test_apply_displacement_field_to_mesh
tests/models/test_voxelise.py::test_entire_workflow
  /home/mxochicale/repositories/Scikit-Surgery/scikit-surgeryvtk/sksurgeryvtk/models/voxelise.py:607: DeprecationWarning: Call to deprecated method ThresholdByLower. (Use 'SetLowerThreshold' and 'SetThresholdFunction' instead.) -- Deprecated since version 9.1.0.
    threshold.ThresholdByLower(0)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

mxochicale added a commit that referenced this issue Feb 1, 2023
@mxochicale
✔️ local unit tests/models/test_vtk_cylinder_model.py; (#203 #187)
5e58a03
mxochicale added a commit that referenced this issue Feb 21, 2023
@mxochicale
✔️ fix local vtk_rendering_generator.py:69:0: C0301: Line too long (9…
6594f22 
…4/80) (line-too-long) (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 21, 2023
@mxochicale
✔️ local tests/widgets/test_rendering_generator.py::test_mask_generat…
e494a26 
…or_w_all_shading (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 21, 2023
@mxochicale
✔️ local tests/widgets/test_rendering_generator.py::test_mask_generat…
616fb90 
…or_w_some_shading (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 22, 2023
@mxochicale
✔️ local tests/widgets/test_rendering_generator.py::test_basic_render…
d9a01a6 
…ing_generator (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 22, 2023
@mxochicale
✔️ adds tests/widgets/test_rendering_generator.py::test_basic_renderi…
c335497 
…ng_generator_zbuffer and passed locally (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 22, 2023
@mxochicale
✔️ refactors tests/models/test_vtk_image_model.py to be passed locally (
4b358b6 
#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 22, 2023
@mxochicale
adds 3.12-dev to ci.yml (#187, #202, #203)
9d829cb
mxochicale added a commit that referenced this issue Feb 22, 2023
@mxochicale
adds 3.12 to ci.yml experimental (#187, #202, #203)
dcb6aea
mxochicale added a commit that referenced this issue Feb 22, 2023
@mxochicale
updates version of actions in ci.yml (#187, #202, #203)
d5f5149
mxochicale added a commit that referenced this issue Feb 22, 2023
@mxochicale
setting up 3.12-dev to ci.yml (#187, #202, #203)
6049a22
mxochicale added a commit that referenced this issue Feb 23, 2023
@mxochicale
✔️ passed local test of tests/widgets/test_interlaced_stereo_window.p…
4d1bd38 
…y::test_stereo_overlay_window but screen is black; refactors VTKStereoInterlacedWindow; (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 27, 2023
@mxochicale
✔️ 155 tests passed locally; adds decorator @skiplinux_pytest tests/w…
989f9d7 
…idgets/test_rendering_generator.py; (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 27, 2023
@mxochicale
renames decorator as @skip_pytest_in_linux (#187, #202, #203)
aad044d
mxochicale added a commit that referenced this issue Feb 27, 2023
@mxochicale
✔️ 156 tests passed locally; adding tests/text/test_vtk_text.py::test…
7e43034 
…_window_resize (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 27, 2023
@mxochicale
✔️ adds decorator @skip_pytest_in_oss to skip in all OSs tests/text/t…
fa1f29e 
…est_vtk_text.py::test_window_resize (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 27, 2023
@mxochicale
✔️ 154 tests passed locally; adds decorator @skip_pytest_in_oss tests…
5852916 
…/widgets/test_interlaced_stereo_window.py (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 28, 2023
@mxochicale
locally pass by uncommenting first lines of tests/widgets/test_lus_si…
09bd3ef 
…mulator.py (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 28, 2023
@mxochicale
local failures by uncommenting lus.VTKLUSSimulator in tests/widgets/t…
9e42d27 
…est_lus_simulator.py::test_basic_rendering_generator (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 28, 2023
@mxochicale
unit test in linux is not stable as it fails due to innapropriate cla…
18aa2a6 
…ss inherirtance; also refactors prints in tests/widgets/test_lus_simulator.py::test_basic_rendering_generator (#187, #202, #203)
mxochicale added a commit that referenced this issue Feb 28, 2023
@mxochicale
unit test in linux is not stable as it fails due to innapropriate cla…
1d0a681 
…ss inherirtance; tests/widgets/test_lus_simulator.py::test_matrices_rendering_generator (#187, #202, #203)
mxochicale added a commit that referenced this issue Mar 1, 2023
@mxochicale
adds decorator @skip_pytest_in_linux_and_none_ci for tests/widgets/te…
a9c67fb 
…st_lus_simulator.py (#187, #202, #203)
mxochicale added a commit that referenced this issue Mar 1, 2023
@mxochicale
removes python-ver 3.7 in ci.yml due to end-of-support 2023-06-27; de…
fc6e295 
…ploy in ubuntu22.02 py38; updates pyversion to 3.8 in tox (#187, #202, #203)
mxochicale added a commit that referenced this issue Mar 1, 2023
@mxochicale
comments widget_vtk_overlay.Start() in tests/camera/test_liver_overla…
1073cc9 
…y.py::test_overlay_liver_points (#187, #202, #203)
mxochicale added a commit that referenced this issue Mar 1, 2023
@mxochicale
removes docs/tutorials/overlay_window.ipynb and updates tox for docs (#…
a2ac8ce 
…187, #202, #203, #206)
@mxochicale mxochicale mentioned this issue Mar 2, 2023
Closed
@mxochicale
Copy link
Contributor Author

  • Local unit tests in ubuntu22.04x64:
===== 154 passed, 9 skipped, 13 warnings in 24.96s ====
  • Remote unit tests for py38, py39, p10, py11 and deploy (failed in experimental py12):
test (ubuntu-latest, 3.8, false)
============ 156 passed, 7 skipped, 13 warnings in 74.11s (0:01:14) ============
...
test (3.11, ubuntu-latest, true)
============ 156 passed, 7 skipped, 13 warnings in 66.72s (0:01:06) ============
test (3.11, macos-latest, true)
============ 161 passed, 2 skipped, 13 warnings in 88.76s (0:01:28) ============
test (3.11, windows-latest, true)
=========== 161 passed, 2 skipped, 13 warnings in 95.39s (0:01:35) ============

See all and further details: https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4305704952

@mxochicale mxochicale mentioned this issue Mar 2, 2023
Merged
@mxochicale
Copy link
Contributor Author

Just adding the following message as part of going with a more systemic approach to perform local and remote unit tests:

Summary of unit tests for py38

The following is a quick summary of local and remote unit tests. See more for remote tests: https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567531

local ubuntu22.04x64

# pytest -v -s tests
============ 154 passed, 9 skipped, 13 warnings in 25.55s ============

tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK pipelines and pyside workflo...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK p...)
tests/widgets/test_lus_simulator.py::test_basic_rendering_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME because of issues with VTK pipe...)
tests/widgets/test_lus_simulator.py::test_matrices_rendering_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME because of issues with VTK p...)
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK pi...)
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator_zbuffer SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues wit...)
tests/widgets/test_rendering_generator.py::test_mask_generator SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK pipelines and...)
tests/widgets/test_rendering_generator.py::test_mask_generator_w_all_shading SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VTK...)
tests/widgets/test_rendering_generator.py::test_mask_generator_w_some_shading SKIPPED (for [Linux OSs with CI=[None] with RUNNER_OS=[None] local/precision-5570 with ubuntu:GNOME due to issues with VT...)


# coverage report -m
py38: commands[2]> coverage report -m
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk/camera/__init__.py                                 0      0   100%
sksurgeryvtk/camera/vtk_camera_model.py                        82      8    90%   20-23, 161, 164, 175-176
sksurgeryvtk/models/__init__.py                                 0      0   100%
sksurgeryvtk/models/outline_render.py                          14      0   100%
sksurgeryvtk/models/surface_model_loader.py                    83      6    93%   103, 108, 113, 118, 123, 148
sksurgeryvtk/models/voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, 406, 495, 502-503, 507, 519, 594-596
sksurgeryvtk/models/vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk/models/vtk_base_model.py                          40      1    98%   101
sksurgeryvtk/models/vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk/models/vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk/models/vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk/models/vtk_point_model.py                         57      1    98%   104
sksurgeryvtk/models/vtk_sphere_model.py                        45      0   100%
sksurgeryvtk/models/vtk_surface_model.py                      120      3    98%   62, 161, 242
sksurgeryvtk/models/vtk_surface_model_directory_loader.py     100      7    93%   55, 136-139, 142-143, 193
sksurgeryvtk/text/__init__.py                                   0      0   100%
sksurgeryvtk/text/text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk/utils/__init__.py                                  0      0   100%
sksurgeryvtk/utils/matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk/utils/platform_utils.py                            7      7     0%   3-19
sksurgeryvtk/utils/polydata_utils.py                           31      0   100%
sksurgeryvtk/utils/projection_utils.py                         66      1    98%   43
sksurgeryvtk/widgets/__init__.py                                0      0   100%
sksurgeryvtk/widgets/vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk/widgets/vtk_lus_simulator.py                      87     77    11%   47-95, 122-177, 191-221
sksurgeryvtk/widgets/vtk_overlay_window.py                    234     36    85%   81, 169, 178-179, 183-184, 198, 267, 368, 388, 393-397, 424, 433-434, 440, 446, 462-469, 499-514, 522-527
sksurgeryvtk/widgets/vtk_rendering_generator.py               105     83    21%   53-93, 97-98, 107-109, 118-119, 125-131, 153-161, 170-174, 182-190, 197-206, 220-243
sksurgeryvtk/widgets/vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1997    445    78%

CI ubuntu-latest, 3.8

================= 156 passed, 7 skipped, 13 warnings in 57.73s =================

tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Linux ...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator SKIPPED
tests/widgets/test_rendering_generator.py::test_basic_rendering_generator_zbuffer SKIPPED
tests/widgets/test_rendering_generator.py::test_mask_generator SKIPPED
tests/widgets/test_rendering_generator.py::test_mask_generator_w_all_shading SKIPPED
tests/widgets/test_rendering_generator.py::test_mask_generator_w_some_shading SKIPPED


Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk/camera/__init__.py                                 0      0   100%
sksurgeryvtk/camera/vtk_camera_model.py                        82      4    95%   161, 164, 175-176
sksurgeryvtk/models/__init__.py                                 0      0   100%
sksurgeryvtk/models/outline_render.py                          14      0   100%
sksurgeryvtk/models/surface_model_loader.py                    83      6    93%   103, 108, 113, 118, 123, 148
sksurgeryvtk/models/voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, 406, 495, 502-503, 507, 519, 594-596
sksurgeryvtk/models/vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk/models/vtk_base_model.py                          40      1    98%   101
sksurgeryvtk/models/vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk/models/vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk/models/vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk/models/vtk_point_model.py                         57      1    98%   104
sksurgeryvtk/models/vtk_sphere_model.py                        45      0   100%
sksurgeryvtk/models/vtk_surface_model.py                      120      2    98%   161, 242
sksurgeryvtk/models/vtk_surface_model_directory_loader.py     100      7    93%   55, 136-139, 142-143, 193
sksurgeryvtk/text/__init__.py                                   0      0   100%
sksurgeryvtk/text/text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk/utils/__init__.py                                  0      0   100%
sksurgeryvtk/utils/matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk/utils/platform_utils.py                            7      7     0%   3-19
sksurgeryvtk/utils/polydata_utils.py                           31      0   100%
sksurgeryvtk/utils/projection_utils.py                         66      1    98%   43
sksurgeryvtk/widgets/__init__.py                                0      0   100%
sksurgeryvtk/widgets/vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk/widgets/vtk_lus_simulator.py                      87      0   100%
sksurgeryvtk/widgets/vtk_overlay_window.py                    234     34    85%   81, 169, 178-179, 198, 267, 368, 388, 393-397, 424, 433-434, 440, 446, 462-469, 499-514, 522-527
sksurgeryvtk/widgets/vtk_rendering_generator.py               105     21    80%   118-119, 154, 157, 170-174, 182-190, 202, 227-228, 241
sksurgeryvtk/widgets/vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1[997](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567214#step:6:998)    299    85%

CI macos-latest, 3.8

============ 161 passed, 2 skipped, 13 warnings in 91.37s (0:01:31) ============

tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Darwin...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED


Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk/camera/__init__.py                                 0      0   100%
sksurgeryvtk/camera/vtk_camera_model.py                        82      4    95%   161, 164, 175-176
sksurgeryvtk/models/__init__.py                                 0      0   100%
sksurgeryvtk/models/outline_render.py                          14      0   100%
sksurgeryvtk/models/surface_model_loader.py                    83      5    94%   103, 108, 113, 118, 123
sksurgeryvtk/models/voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, 406, 495, 502-503, 507, 519, 594-596
sksurgeryvtk/models/vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk/models/vtk_base_model.py                          40      1    98%   101
sksurgeryvtk/models/vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk/models/vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk/models/vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk/models/vtk_point_model.py                         57      1    98%   104
sksurgeryvtk/models/vtk_sphere_model.py                        45      0   100%
sksurgeryvtk/models/vtk_surface_model.py                      120      2    98%   161, 242
sksurgeryvtk/models/vtk_surface_model_directory_loader.py     100      7    93%   55, 136-139, 142-143, 193
sksurgeryvtk/text/__init__.py                                   0      0   100%
sksurgeryvtk/text/text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk/utils/__init__.py                                  0      0   100%
sksurgeryvtk/utils/matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk/utils/platform_utils.py                            7      7     0%   3-19
sksurgeryvtk/utils/polydata_utils.py                           31      0   100%
sksurgeryvtk/utils/projection_utils.py                         66      1    98%   43
sksurgeryvtk/widgets/__init__.py                                0      0   100%
sksurgeryvtk/widgets/vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk/widgets/vtk_lus_simulator.py                      87      0   100%
sksurgeryvtk/widgets/vtk_overlay_window.py                    234     25    89%   81, 178-179, 198, 267, 368, 388, 393-397, [424](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567895#step:7:425), [433](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567895#step:7:434)-[434](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567895#step:7:435), 440, 446, 499-514, 522-527
sksurgeryvtk/widgets/vtk_rendering_generator.py               105      0   100%
sksurgeryvtk/widgets/vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1997    268    87%

CI windows-latest, 3.8

=========== 161 passed, 2 skipped, 13 warnings in 73.08s (0:01:13) ============
tests/text/test_vtk_text.py::test_window_resize SKIPPED (for [Window...)
tests/widgets/test_interlaced_stereo_window.py::test_stereo_overlay_window SKIPPED

Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
sksurgeryvtk\camera\__init__.py                                 0      0   100%
sksurgeryvtk\camera\vtk_camera_model.py                        82      4    95%   161, 164, 175-176
sksurgeryvtk\models\__init__.py                                 0      0   100%
sksurgeryvtk\models\outline_render.py                          14      0   100%
sksurgeryvtk\models\surface_model_loader.py                    83      5    94%   103, 108, 113, 118, 123
sksurgeryvtk\models\voxelise.py                               336     28    92%   168, 191, 197-207, 299, 302, 323-325, 351-352, 364-365, 406, 495, 502-503, 507, 519, 594-596
sksurgeryvtk\models\vtk_base_actor.py                          48      3    94%   105-109
sksurgeryvtk\models\vtk_base_model.py                          40      1    98%   101
sksurgeryvtk\models\vtk_cylinder_model.py                      22      0   100%
sksurgeryvtk\models\vtk_grid_model.py                          55      9    84%   54, 64, 85, 93-96, 105-108
sksurgeryvtk\models\vtk_image_model.py                         21      2    90%   43-44
sksurgeryvtk\models\vtk_point_model.py                         57      1    98%   104
sksurgeryvtk\models\vtk_sphere_model.py                        45      0   100%
sksurgeryvtk\models\vtk_surface_model.py                      120      2    98%   161, 242
sksurgeryvtk\models\vtk_surface_model_directory_loader.py     100     10    90%   55, 57, 59, 136-139, 142-143, 167, 193
sksurgeryvtk\text\__init__.py                                   0      0   100%
sksurgeryvtk\text\text_overlay.py                             105     26    75%   63, 71, 79, 87, 208-211, 221-228, 235-261
sksurgeryvtk\utils\__init__.py                                  0      0   100%
sksurgeryvtk\utils\matrix_utils.py                             46      4    91%   80, 107, 126-127
sksurgeryvtk\utils\platform_utils.py                            7      7     0%   3-19
sksurgeryvtk\utils\polydata_utils.py                           31      0   100%
sksurgeryvtk\utils\projection_utils.py                         66      1    98%   43
sksurgeryvtk\widgets\__init__.py                                0      0   100%
sksurgeryvtk\widgets\vtk_interlaced_stereo_window.py          126     98    22%   38-112, 119-120, 127-128, 142, 146, 150, 161-176, 179-181, 188-192, 200-203, 211-212, 221-222, 230-231, 240-245, 255-256, 264-265, 271-278, 286-288
sksurgeryvtk\widgets\vtk_lus_simulator.py                      87      0   100%
sksurgeryvtk\widgets\vtk_overlay_window.py                    234     25    89%   81, 178-179, 198, 267, 368, 388, 393-397, 424, 433-434, 440, 446, 499-[514](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567531#step:7:515), [522](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567531#step:7:523)-[527](https://github.com/SciKit-Surgery/scikit-surgeryvtk/actions/runs/4324128024/jobs/7548567531#step:7:528)
sksurgeryvtk\widgets\vtk_rendering_generator.py               105      0   100%
sksurgeryvtk\widgets\vtk_reslice_widget.py                    167     45    73%   24, 129, 133-140, 146-147, 152-153, 180-182, 217-219, 227-230, 245-248, 279, 285-290, 314-316, 321-328, 335-341
-----------------------------------------------------------------------------------------
TOTAL                                                        1997    271    86%

@mxochicale mxochicale mentioned this issue Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxochicale mxochicale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thompson318 @mxochicale