Restructure files, add abstract types for problems #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ECE return an FODESolution
Co-authored-by: Qingyu Qu <52615090+ErikQQY@users.noreply.github.com>
Working pipece
…ract types for the different types of algorithms.
… Added abstract types for different algorithms.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 73.63% 73.63%
=======================================
Files 48 50 +2
Lines 3698 3698
=======================================
Hits 2723 2723
Misses 975 975
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ErikQQY
requested changes
Jul 19, 2022
|
The CI all pass now! Let's merge!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that all of the FDE problems and solution types were in the PECE.jl file, so I thought I could move them to their own separate files to help organization. I also added some abstract types, to represent algorithms for solving the different kinds of FDE problems. For example I added
FODESystemAlgorithm <: AbstractFDEAlgorithmto represent algorithms that solve FODESystems. I thought this might help with dispatch as well as maybe error handling if the wrong type of algorithm is used with the wrong type of problem.