Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fullquery swagger documentation #672

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Update fullquery swagger documentation #672

merged 2 commits into from
Aug 21, 2023

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented Aug 18, 2023

Description

This PR updates the fullquery swagger configuration for datasets, proposals and samples.
The fields parameter description and options have been updated to match the correct syntax for each one of them,

Motivation

The syntax and the subfields of the fields parameter was not clear for the fullquery endpoints of datasets, proposals, and samples

Fixes:

  • added description for the fields parameters in the swagger configuration

Changes:

  • datasets.controller
  • proposals.controller
  • samples.controlle
  • common.utils

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

Copy link
Contributor

@Junjiequan Junjiequan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nitrosx nitrosx merged commit b6e19da into master Aug 21, 2023
5 checks passed
@nitrosx nitrosx deleted the swap-3430 branch August 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants