Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump mongoose from 6.10.3 to 7.4.3 #662

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 14, 2023

Bumps mongoose from 6.10.3 to 7.4.3.

Release notes

Sourced from mongoose's releases.

7.4.3 / 2023-08-11

  • fix: avoid applying map property getters when saving #13704 #13657
  • fix(query): allow deselecting discriminator key #13722 #13679
  • types(models+query): return lean type when passing QueryOptions with lean: true to relevant model functions like find() and findOne() #13721 #13705
  • types(schema): correct return type for Schema.prototype.indexes() #13718 #13702
  • types: allow accessing options from pre middleware #13708 #13633
  • types: add UpdateQueryKnownOnly type for stricter UpdateQuery type checking #13699 #13630
  • types(schema): support required: { isRequired: true } syntax in schema definition #13680
  • docs(middleware): clarify that doc.deleteOne() doesn't run query middleware currently #13707 #13669

7.4.2 / 2023-08-03

  • fix(model): avoid hanging on empty bulkWrite() with ordered: false #13684 #13664
  • fix: Document.prototype.isModified support for a string of keys as first parameter #13674 #13667 gastoncasini
  • fix: disable id virtual if alias:id set #13654 #13650
  • fix: support timestamps:false on bulkWrite with updateOne and updateMany #13649 #13611
  • docs(typescript): highlight auto type inference for methods and statics, add info on using methods with generics #13696 #12942
  • docs(middleware): fix old example using post('remove') #13683 #13518
  • docs(deprecations): quick fix for includeResultMetadata docs #13695

7.4.1 / 2023-07-24

  • fix(document): correctly clean up nested subdocs modified state on save() #13644 #13609
  • fix(schema): avoid propagating toObject.transform and toJSON.transform option to implicitly created schemas #13634 #13599
  • fix: prevent schema options overwriting user defined writeConcern #13612 #13592
  • types: correctly handle pre('deleteOne', { document: true }) #13632
  • types(schema): handle type: Schema.Types.Map in TypeScript #13628
  • types: Add inline comment to to tell the default value of the runValidator flag in the queryOptions types #13636 omran95
  • docs: rework several code examples that still use callbacks #13635 #13616
  • docs: remove callbacks from validation description #13638 #13501

7.4.0 / 2023-07-18

  • perf: speed up mapOfSubdocs benchmark by 4x by avoiding unnecessary O(n^2) loop in getPathsToValidate() #13614
  • feat: upgrade to MongoDB Node.js driver 5.7.0 #13591
  • feat: support generating custom cast error message with a function #13608 #3162
  • feat(query): support MongoDB driver's includeResultMetadata option for findOneAndUpdate #13584 #13539
  • feat(connection): add Connection.prototype.removeDb() for removing a related connection #13580 #11821
  • feat(query): delay converting documents into POJOs until query execution, allow querying subdocuments with defaults disabled #13522
  • feat(model): add option "aggregateErrors" for create() #13544 hasezoey
  • feat(schema): add collectionOptions option to schemas #13513
  • fix: move all MongoDB-specific connection logic into driver layer, add createClient() method to handle creating MongoClient #13542
  • fix(document): allow setting keys with dots in mixed paths underneath nested paths #13536
  • types: augment bson.ObjectId instead of adding on own type #13515 #12537 hasezoey
  • docs(guide): fix md lint #13593 hasezoey
  • docs: changed the code from 'await author.save()' to 'await story1.save()' #13596 SomSingh23

7.3.4 / 2023-07-12

... (truncated)

Changelog

Sourced from mongoose's changelog.

7.4.3 / 2023-08-11

  • fix: avoid applying map property getters when saving #13704 #13657
  • fix(query): allow deselecting discriminator key #13722 #13679
  • types(models+query): return lean type when passing QueryOptions with lean: true to relevant model functions like find() and findOne() #13721 #13705
  • types(schema): correct return type for Schema.prototype.indexes() #13718 #13702
  • types: allow accessing options from pre middleware #13708 #13633
  • types: add UpdateQueryKnownOnly type for stricter UpdateQuery type checking #13699 #13630
  • types(schema): support required: { isRequired: true } syntax in schema definition #13680
  • docs(middleware): clarify that doc.deleteOne() doesn't run query middleware currently #13707 #13669

7.4.2 / 2023-08-03

  • fix(model): avoid hanging on empty bulkWrite() with ordered: false #13684 #13664
  • fix: Document.prototype.isModified support for a string of keys as first parameter #13674 #13667 gastoncasini
  • fix: disable id virtual if alias:id set #13654 #13650
  • fix: support timestamps:false on bulkWrite with updateOne and updateMany #13649 #13611
  • docs(typescript): highlight auto type inference for methods and statics, add info on using methods with generics #13696 #12942
  • docs(middleware): fix old example using post('remove') #13683 #13518
  • docs(deprecations): quick fix for includeResultMetadata docs #13695

6.11.5 / 2023-08-01

  • fix(schema): make Schema.prototype.clone() avoid creating different copies of subdocuments and single nested paths underneath single nested paths #13671 #13626
  • fix: custom debug function not processing all args #13418

7.4.1 / 2023-07-24

  • fix(document): correctly clean up nested subdocs modified state on save() #13644 #13609
  • fix(schema): avoid propagating toObject.transform and toJSON.transform option to implicitly created schemas #13634 #13599
  • fix: prevent schema options overwriting user defined writeConcern #13612 #13592
  • types: correctly handle pre('deleteOne', { document: true }) #13632
  • types(schema): handle type: Schema.Types.Map in TypeScript #13628
  • types: Add inline comment to to tell the default value of the runValidator flag in the queryOptions types #13636 omran95
  • docs: rework several code examples that still use callbacks #13635 #13616
  • docs: remove callbacks from validation description #13638 #13501

7.4.0 / 2023-07-18

  • perf: speed up mapOfSubdocs benchmark by 4x by avoiding unnecessary O(n^2) loop in getPathsToValidate() #13614
  • feat: upgrade to MongoDB Node.js driver 5.7.0 #13591
  • feat: support generating custom cast error message with a function #13608 #3162
  • feat(query): support MongoDB driver's includeResultMetadata option for findOneAndUpdate #13584 #13539
  • feat(connection): add Connection.prototype.removeDb() for removing a related connection #13580 #11821
  • feat(query): delay converting documents into POJOs until query execution, allow querying subdocuments with defaults disabled #13522
  • feat(model): add option "aggregateErrors" for create() #13544 hasezoey
  • feat(schema): add collectionOptions option to schemas #13513
  • fix: move all MongoDB-specific connection logic into driver layer, add createClient() method to handle creating MongoClient #13542
  • fix(document): allow setting keys with dots in mixed paths underneath nested paths #13536
  • types: augment bson.ObjectId instead of adding on own type #13515 #12537 hasezoey

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 14, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 14, 2023

The following labels could not be found: npm.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mongoose-7.4.3 branch 2 times, most recently from bb257f1 to e501f07 Compare August 15, 2023 11:21
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mongoose-7.4.3 branch 15 times, most recently from ccd189d to 2227cf3 Compare August 22, 2023 09:48
Bumps [mongoose](https://github.com/Automattic/mongoose) from 6.10.3 to 7.4.3.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md)
- [Commits](Automattic/mongoose@6.10.3...7.4.3)

---
updated-dependencies:
- dependency-name: mongoose
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/mongoose-7.4.3 branch from 2227cf3 to e1b1a47 Compare August 22, 2023 09:58
@minottic
Copy link
Contributor

I noticed that the tests on delete, for all controllers, do not cover cases when the document is not deleted, as the return code for a deletion or "a document not found thus not deleted" is 200.

We can add this check (in a later PR) in the tests, by checking that the returned object after the delete is not empty (as it's returned as stated here) or we could return a different status code (404) if no document is deleted.

I prefer the second option, but we might need to catch it with the clients.

@nitrosx, @dylanmcreynolds what do you think?

@nitrosx
Copy link
Contributor

nitrosx commented Aug 25, 2023

@minottic : I agree with you: if the document is not deleted, I would prefer to receive a different code, like 404.

Merging the PR as the tests are passing.
We will open an issue regarding the tests

@nitrosx nitrosx merged commit 0892353 into master Aug 25, 2023
5 checks passed
@nitrosx nitrosx deleted the dependabot/npm_and_yarn/mongoose-7.4.3 branch August 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants