Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed sharing dataset 500 error #468

Merged

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Apr 25, 2023

Description

Fixed some problematic types for /:pid/appendToArrayField endpoint.

Motivation

Share datasets to others causing 500 error

Fixes:

Screenshare.-.2023-04-25.5_07_12.PM.mp4

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

Copy link
Contributor

@nitrosx nitrosx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that the changed from body to query param is a drastic change that have unforeseen consequences.

src/datasets/datasets.controller.ts Show resolved Hide resolved
@Junjiequan Junjiequan requested a review from nitrosx April 27, 2023 11:16
@nitrosx nitrosx merged commit aaaf4a8 into master Apr 28, 2023
@nitrosx nitrosx deleted the SWAP-3157-scicat-fe-be-fe-report-successful-sharing-of-a-da branch April 28, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants