Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument endpoint and tests #448

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Instrument endpoint and tests #448

merged 1 commit into from
Apr 18, 2023

Conversation

nitrosx
Copy link
Contributor

@nitrosx nitrosx commented Apr 18, 2023

Description

This PR fixes the filter issues on Instrument endpoint and extends the API tests.

Motivation

Instrument endpoint was returning the incorrect instrument when filtering was applied or when the instrument id was being passed. Same for the patch one.

Fixes:

  • filtering in main endpoint, path and findone

Changes:

  • casl ability factory
  • instrument controller, service, and schema
  • data for test
  • instrument tests

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@nitrosx nitrosx merged commit 7946e76 into master Apr 18, 2023
@nitrosx nitrosx deleted the swap-3226 branch April 18, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant