Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Figma icon import CLI #1754

Merged
merged 38 commits into from
Aug 23, 2024
Merged

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Aug 15, 2024

Relates to #939

Implement Figma CLI command to import and optimize SVG icons from Figma.
Also added a GitHub action which is run daily to create a PR with updated icons.

Checklist

  • The added / edited code has been documented with JSDoc
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

larsrickert and others added 9 commits August 14, 2024 17:19
This is an auto-generated pull request. All Figma icons have been
updated.

Co-authored-by: larsrickert <67898185+larsrickert@users.noreply.github.com>
This is an auto-generated pull request. All Figma icons have been
updated.

Co-authored-by: larsrickert <67898185+larsrickert@users.noreply.github.com>
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 56a5275

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@sit-onyx/figma-utils Minor
@sit-onyx/icons Major
demo-app Patch
playground Patch
sit-onyx Major
@sit-onyx/storybook-utils Major
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert changed the title [DRAFT] feat: implement Figma icon import CLI feat: implement Figma icon import CLI Aug 16, 2024
@larsrickert larsrickert marked this pull request as ready for review August 16, 2024 14:31
@larsrickert larsrickert requested a review from a team as a code owner August 16, 2024 14:31
@larsrickert
Copy link
Collaborator Author

larsrickert commented Aug 16, 2024

Notes before my vacation:

  • you can already review this PR it if you'd like
  • I discussed with Martin that we will align a date together with the responsible UX collegues who will maintain the icons in the future. Starting from this date, we will sync/update the latest icons once and then handle the Figma file as single source of truth. Also CoreUI will need to be updated then to use the onyx icon library.
  • missing feature of Implement icon from figma downloading cli tool #939: create a changeset in the pipeline and ideally include a list of added/changed/removed icons (we could amybe use git CLI for this)

@BoppLi BoppLi self-assigned this Aug 19, 2024
BoppLi
BoppLi previously requested changes Aug 19, 2024
.changeset/slow-dryers-knock.md Outdated Show resolved Hide resolved
.github/workflows/import-figma-icons.yml Show resolved Hide resolved
packages/icons/src/metadata.json Show resolved Hide resolved
@BoppLi
Copy link
Contributor

BoppLi commented Aug 19, 2024

Also CoreUI will need to be updated then to use the onyx icon library.

afaik STACKIT is also a consumer of the current icon lib repo that Lily maintains. maybe put it on the ticket to inform them about the change of procedure aswell? if it isn't already in the backlog

@larsrickert
Copy link
Collaborator Author

Also CoreUI will need to be updated then to use the onyx icon library.

afaik STACKIT is also a consumer of the current icon lib repo that Lily maintains. maybe put it on the ticket to inform them about the change of procedure aswell? if it isn't already in the backlog

I am in contact with Lilia and Frank on this :)

@MajaZarkova MajaZarkova self-assigned this Aug 22, 2024
MajaZarkova
MajaZarkova previously approved these changes Aug 22, 2024
@larsrickert larsrickert merged commit b525ca5 into main Aug 23, 2024
19 checks passed
@larsrickert larsrickert deleted the feat/939-figma-icon-cli branch August 23, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants