Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon changeset not being released #1814

Closed
larsrickert opened this issue Aug 29, 2024 · 0 comments · Fixed by #1858
Closed

Fix icon changeset not being released #1814

larsrickert opened this issue Aug 29, 2024 · 0 comments · Fixed by #1858
Assignees
@larsrickert
Labels
bug Something isn't working or not shown correctly dev Requires technical expertise
Milestone
Product improvements

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Aug 29, 2024 •
edited
Loading

In #939 we implemented changeset generation for changed icons in our icon import workflow.

The changeset files are generated correctly and the changeset PR bot also detects it:

Image

However, as seen in the screenshot above it says "This PR includes no changesets" and merging the PR does then not release a new version, see #1809
@larsrickert larsrickert self-assigned this Aug 29, 2024
@larsrickert larsrickert added bug Something isn't working or not shown correctly dev Requires technical expertise labels Aug 29, 2024
@larsrickert larsrickert removed their assignment Aug 29, 2024
@mj-hof mj-hof added this to the Product improvements milestone Sep 10, 2024
@larsrickert larsrickert self-assigned this Sep 12, 2024
@larsrickert larsrickert mentioned this issue Sep 12, 2024
Merged
larsrickert added a commit that referenced this issue Sep 12, 2024
@larsrickert
chore: fix icon library release (#1858)
a10f29d 
closes #1814

Fixes the issue that our icon library is not released when automated PRs
for Figma imports are done.
Also fixes the issue that the documentation did not contain the latest
changelogs when a release is done because it was build before the
changelogs were generated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsrickert larsrickert

Labels
bug Something isn't working or not shown correctly dev Requires technical expertise
Projects
onyx
Status: Done
Milestone
Product improvements
Development

Successfully merging a pull request may close this issue.

chore: fix icon library release SchwarzIT/onyx
2 participants
@larsrickert @mj-hof