Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear buffer after multicastAlarm_ric received #370

Merged
merged 7 commits into from
Aug 16, 2018

Conversation

f-kessler
Copy link
Contributor

Fix for networks that mix normal alarms with multicastAlarms (delimiter needs to be deactivated) and require a large value for the multicastAlarm_ignore_time.
If the delimiter is deactivated, RICs in the buffer will be deleted only if they are older than multicastAlarm_ignore_time. This could cause a mixture of RICs of the current and the privious multicastAlarm. This problem can be fixed, by clearing the buffer after the multicastAlarm sequence has finished.

Develop Update from original
Fix for networks that mix normal alarms with multicastAlarms (delimiter needs to be deactivated).
If the delimiter is deactivated, RICs in the buffer will be deleted only if they are older than multicastAlarm_ignore_time. This could cause a mixture of RICs of the current and the privious multicastAlarm. This problem can be fixed, by clearing the buffer after the multicastAlarm sequence has finished.
@Schrolli91
Copy link
Owner

@f-kessler please add also a changlog entry before i merge this

@NinavonReich
Copy link

Anzumerken ist, dass man unbedingt auf "doubleFilter_check_msg" achten sollte.
Ansonsten bedanke ich mich von ganzen Herzen - bei mir läuft nun alles tip top! ♥

@Schrolli91
Copy link
Owner

@NinavonReich was meinst du mit - Drauf achten?

@Schrolli91 Schrolli91 merged commit 9ad6da6 into Schrolli91:develop Aug 16, 2018
@ghost ghost removed the Review needed label Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants