Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab-ci] Various fixes for scheme #1542

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

AKorezin
Copy link
Contributor

@AKorezin AKorezin commented Mar 29, 2021

Why did I create this PR

  1. I want to fix definitions for job variables.
    But to after fixing variables I've found that only top level variables support object type.
  2. So to test this I have to create positive and negative tests.
  3. To create negative tests I have to fix gitlab-ci scheme.

PR details

Fix gitlab-ci to pass schema test to support negative tests
Add secrets definition with full inner object structure.

Create global variables definition with additional object property for prefill variables.

# This is valid
variables:
  VARIABLE:
    value: DEFAULT
    description: "Variable test"

Remove additional object property from job variables, because objects are only supported at top level.
Ref: #1504

# This is invalid
test_job:
  script:
    - true
  variables:
    VARIABLE:
      value: DEFAULT
      description: "Variable test"

Add positive test for variables.
Add negative test for variables.

Fix gitlab-ci to pass schema test to support negative tests
Add secrets definition with full inner object structure

Create global variables definition with additional object property
Remove additional object property from job variables
Add positive test for variables
Add negative test for variables
@AKorezin AKorezin changed the title Gitlab ci fix [gitlab-ci] Various fixes for schema Mar 29, 2021
@AKorezin AKorezin changed the title [gitlab-ci] Various fixes for schema [gitlab-ci] Various fixes for scheme Mar 29, 2021
@madskristensen madskristensen merged commit 840b97a into SchemaStore:master Mar 29, 2021
@madskristensen
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants