Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows
assign
to take a map of values, like Phoenix does.Motivation and Context
When working on a Scenic project, we captured the entire
scene.assigns
and transformed a few values. We received an error when trying to assign this resulting map back to the scene, sincescene.assigns
gave us a map. We referenced Phoenix's behavior ofassigns
since that was motivation for bringing it into Scenic, and Phoenix does in fact allow both a keyword list or map as assigns. Therefore we thought we should allow for assigning a map in Scenic as well.Happy to discuss if this either isn't desired or should be implemented differently.
Types of changes
not work as expected)
but make things better)
Checklist