Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that the Primitives.group does not take a primitive #168

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

axelson
Copy link
Collaborator

@axelson axelson commented Jul 4, 2019

Document that the Primitives.group does not take a primitive

Motivation and Context

I didn't understand at first why I was getting a function clause error when passing in a primitive even though the documentation says that it is accepted. So I'm fixing the documentation.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature
    but make things better)

Checklist

  • Check other PRs and make sure that the changes are not done yet.
  • The PR title is no longer than 64 characters.

@axelson
Copy link
Collaborator Author

axelson commented Jul 4, 2019

Related: #27

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          87       87           
  Lines        2343     2343           
=======================================
  Hits         2012     2012           
  Misses        331      331
Impacted Files Coverage Δ
lib/scenic/primitives.ex 93.15% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e4952...0d2a1bf. Read the comment docs.

@boydm boydm merged commit facd971 into ScenicFramework:master Jul 4, 2019
@axelson axelson deleted the document-group-no-primitive branch July 5, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants