Move C build products under _build #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build products were being stored in the source directory. This was causing trouble when building for different architectures since build products for one could be used for the other. The workaround was to build clean when switching. `elixir_make` v0.5.0 makes it easier to move build products under the appropriate directory under `_build` by exporting the `MIX_COMPILE_PATH` environment variable. This updates the `elixir_make` dep to at least v0.5.0 and uses the new environment variables.
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 80 80
Lines 1912 1912
=======================================
Hits 1748 1748
Misses 164 164Continue to review full report at Codecov.
|
|
Is this something you need in a minor release or can it wait until 0.10.0 (which will be after lonestar...)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build products were being stored in the source directory. This was
causing trouble when building for different architectures since build
products for one could be used for the other. The workaround was to
build clean when switching.
elixir_makev0.5.0 makes it easier to movebuild products under the appropriate directory under
_buildbyexporting the
MIX_COMPILE_PATHenvironment variable. This updates theelixir_makedep to at least v0.5.0 and uses the new environmentvariables.
Motivation and Context
Types of changes
not work as expected)
but make things better)
Checklist