Sync with upstream v9 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
approved these changes
May 13, 2024
Since for the check changelog check (added in #56) to pass, we actually need a changelog to which we can add entries. I've backfilled recent changes based on the Git history. The buildpack doesn't tag versions, so I've used dates only. Closes W-8726144.
Enables the bash `pipefail` mode, which ensures that a failure in a command prior to a pipe correctly causes the script to exit 1. Without this, failures during the `apt-get` and `curl` invocations were ignored and the compile marked as a success. At best this leads to confusing errors in later buildpacks (if build time dependencies are missing), and at worst this could cause runtime failures for packages not used during the build, but required by the app at runtime. Enabling `pipefail` mode required a change to the custom repositories feature, to prevent the build exiting 1 when `grep -s -e "^:repo:"` found no matches (ie when no custom repositories are specified). In addition, the `--show-error` and `--fail` flags have been added to the `curl` call, otherwise non-HTTP 200 exit codes are ignored and the compile similarly marked as successful when it should not have been. Fixes #47. Fixes W-8722791.
In a recent support ticket, a user had copied the example `:repo:` line into their `Aptfile`, which previously referred to the now obsolete "artful" Ubuntu LTS release. This caused the build to fail after #79, when previously the error was ignored. This PR makes the example more clearly just an example, and emphasises that using a custom repository is only necessary if using packages from outside the standard Ubuntu repository. In addition, the bogus `pg` Gem example was removed, since `libpq-dev` is part of the stack image, so we should not be encouraging people to install it unnecessarily.
The error message is output to `stderr` otherwise it won't be shown. Closes GUS-W-8799411. Refs #86.
To pick up #87. Refs GUS-W-8799411.
Switches to the newer label based approach used in eg: https://github.com/heroku/buildpacks-python/blob/main/.github/workflows/check_changelog.yml
* Add `bin/report` script to capture buildpack metadata [W-15039947](https://gus.lightning.force.com/lightning/r/a07EE00001k7v4BYAQ/view)
Includes: - #110
* Fix variable quoting throughout Guards against glob expansion from user input, and works with spaces etc in any path names. Double square brackets do not technically need quoting, but doing it for consistency, as the lines have been touched anyway. Variable assignments, on the other hand, do not require quoting, but I did not remove existing quotes to aid future 'git blame's. * Fix .deb globbing Iterating over 'ls' output breaks with spaces in path names * Use nul byte separators with find/xargs Guards against spaces etc in path/file names
…le line (#112) * Handle when multiple packages are declared on a single line.
* Update CHANGELOG.md --------- Co-authored-by: Rune Soerensen <runesoerensen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested here: https://fku-ferret2.osc-fr1.scalingo.io
Fix #10