-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional caliban endpoint #17
Conversation
# Conflicts: # src/main/g8/build.sbt # src/main/g8/default.properties # src/main/g8/src/main/scala/$package$/Boot.scala # src/main/g8/src/main/scala/$package$/infrastructure/SlickItemRepository.scala
# Conflicts: # src/main/g8/build.sbt # src/main/g8/default.properties # src/main/g8/src/main/scala/$package$/Boot.scala # src/main/g8/src/main/scala/$package$/infrastructure/SlickItemRepository.scala
...ain/g8/src/main/scala/$package$/api/$if(add_caliban_endpoint.truthy)$GraphQLApi.scala$endif$
Outdated
Show resolved
Hide resolved
...ain/g8/src/main/scala/$package$/api/$if(add_caliban_endpoint.truthy)$GraphQLApi.scala$endif$
Outdated
Show resolved
Hide resolved
Does it work?? Actually I'm missing one part (maybe it's automagically covered by caliban somehow - I don't know, don't know the library so far.... :D
|
# Conflicts: # src/main/g8/src/main/scala/$package$/Boot.scala
* Few changes in GraphQL part: - fixed graphiql.html with unnecessary conditionals, - add two more queries and one mutation to make API more complete, - Updated README * formatting fix. * Change ZIO[Any, Throwable, A] into alias Task[A] * Update README.markdown Co-Authored-By: Vladimir Pavkin <vpavkin@gmail.com> * Update README.markdown Co-Authored-By: Vladimir Pavkin <vpavkin@gmail.com> * Update README.markdown Co-Authored-By: Vladimir Pavkin <vpavkin@gmail.com> * Update README.markdown Co-Authored-By: Vladimir Pavkin <vpavkin@gmail.com> * make functions composition consistent Co-authored-by: Vladimir Pavkin <vpavkin@gmail.com>
So this is hanging for long time already :) Should I merge it after #33 is merged? |
runService function and error handling small refactor
# Conflicts: # src/main/g8/build.sbt # src/main/g8/src/main/scala/$package$/Boot.scala # src/main/g8/src/main/scala/$package$/infrastructure/SlickItemRepository.scala
@vpavkin @marioosh sorry I've been delaying it for so long. Looks great. One thing I've been thinking is that in case someone opts out of the GraphQL endpoint, still gets the additional repository and service methods for deletion events, custom search by price etc. Don't you think it would be better if these would also depend on |
@jczuchnowski great catch, I missed that entirely. I can clean it up on monday |
Don't you have holidays on Monday? :) |
Nope, my holidays start on 1st of May:) Actually finished project a day earlier, so plan to merge this today :) |
@jczuchnowski I added a small cool thing to CI - it now runs tests for both caliban and non-caliban versions of the template. will be handy since we have a lot of conditionals there and it's easy to miss something. |
Cleaned everything, at least it seems so :) |
Fix #5
For some reason I bumped into foundweekends/giter8#432, although giter plugin version is up to date.
The only consequence so far is that there's an unneeded html file in resources folder if user opts out of caliban endpoint