-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add recipe for Read Contracts #31
Conversation
@metalboyrick please review |
Hi @od-hunter, I really liked your documentation, we look forward to the changes and final review. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes and you're good!
}; | ||
``` | ||
|
||
By following this guide, you have successfully implemented a contract reader in your dApp that fetches and displays data from a deployed contract using the [`useScaffoldReactContract`](https://github.com/Scaffold-Stark/scaffold-stark-2/blob/main/packages/nextjs/hooks/scaffold-stark/useScaffoldReadContract.ts) hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo (useScaffoldReactContract should be useScaffoldReadContract)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the convention consistent with the other files!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@od-hunter I meant the file name. My bad for the unclear message.
ReadContractDataFromNetwork.md
--> read-contract-data.md
(would prefer this shorter name too)
@metalboyrick @Nadai2010, thank you both for your review. @metalboyrick, I wasn’t entirely clear on the 'convention consistency' feedback, but I’ve made some recent changes that I hope align with your expectations. If not, I would appreciate further clarification to ensure I implement the conventions consistently. |
@metalboyrick, I’ve renamed the document to align with the naming conventions used in the other files. |
Add recipe for Read Contract
Fixes #22
Types of change