-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for BZ#1876220 #9293
Conversation
trigger: test-robottelo |
d40ca21
to
eb2cacd
Compare
Codecov Report
@@ Coverage Diff @@
## 6.10.z #9293 +/- ##
==========================================
+ Coverage 51.99% 52.01% +0.02%
==========================================
Files 69 69
Lines 4533 4533
==========================================
+ Hits 2357 2358 +1
+ Misses 2176 2175 -1
Continue to review full report at Codecov.
|
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test upgrade.
I would be happy to discuss the review comments I wrote if they are not clear enough :)
Requesting changes or answers.
9b27556
to
f2fcb81
Compare
trigger: test-robottelo |
747f171
to
ba16a04
Compare
trigger: test-robottelo |
1f52d5d
to
2f7a473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK with minor docstring comment !
2f7a473
to
21d3529
Compare
trigger: test-robottelo |
PRT build 661 is failing with :
|
Test Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, Looks good 👍
Code quality is failing on dependency installation. Not connected to changes in the PR. |
21d3529
to
4826322
Compare
Test Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
@shubhamsg199 I remember there were a few issues with this test for 7.0 earlier, which can be a reason to rebase this for 6.10.z branch, so can you open a backport PR adding this test in master as well?
7.0 cockpit has workaround. and I am currently looking at it cause it's part of RHEL 9 initiative. Once I am finished I will let you know @shubhamsg199 |
Merging this PR. The checks fails are not related to this PR and a separate PR has been opened to take care of this : #9355 |
Test results: