Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for BZ#1876220 #9293

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

shubhamsg199
Copy link
Contributor

Test results:

$ pytest -k test_positive_cockpit tests/foreman/ui/test_host.py
========================================= test session starts ============================================
platform linux -- Python 3.8.6, pytest-6.2.5, py-1.10.0, pluggy-0.13.1
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/sganar/satellite/robottelo, configfile: pyproject.toml
plugins: services-2.2.1, mock-3.6.1, reportportal-5.0.8, forked-1.3.0, ibutsu-2.0.1, cov-3.0.0, xdist-2.5.0
collected 36 items / 35 deselected / 1 selected                                                                                                  

tests/foreman/ui/test_host.py .                                                                                                            [100%]

================================= 1 passed, 35 deselected in 1451.19s (0:24:11) ===============================

@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: -k 'test_positive_cockpit' tests/foreman/ui/test_host.py
airgun: 657

@shubhamsg199 shubhamsg199 added the 6.10.z Introduced in or relating directly to Satellite 6.10 label Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #9293 (eb2cacd) into 6.10.z (34f3a36) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head eb2cacd differs from pull request most recent head 4826322. Consider uploading reports for the commit 4826322 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           6.10.z    #9293      +/-   ##
==========================================
+ Coverage   51.99%   52.01%   +0.02%     
==========================================
  Files          69       69              
  Lines        4533     4533              
==========================================
+ Hits         2357     2358       +1     
+ Misses       2176     2175       -1     
Impacted Files Coverage Δ
robottelo/decorators/func_locker.py 92.30% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67c9f0...4826322. Read the comment docs.

@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: -k 'test_positive_cockpit' tests/foreman/ui/test_host.py
airgun: 657

Copy link
Contributor

@tstrych tstrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test upgrade.
I would be happy to discuss the review comments I wrote if they are not clear enough :)

Requesting changes or answers.

tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
@shubhamsg199 shubhamsg199 force-pushed the cockpit_6.10 branch 4 times, most recently from 9b27556 to f2fcb81 Compare January 20, 2022 08:14
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: -k 'test_positive_cockpit' tests/foreman/ui/test_host.py

@shubhamsg199 shubhamsg199 force-pushed the cockpit_6.10 branch 2 times, most recently from 747f171 to ba16a04 Compare January 21, 2022 06:28
@devendra104
Copy link
Member

trigger: test-robottelo
pytest: -k 'test_positive_cockpit' tests/foreman/ui/test_host.py

@shubhamsg199 shubhamsg199 force-pushed the cockpit_6.10 branch 2 times, most recently from 1f52d5d to 2f7a473 Compare January 25, 2022 16:42
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with minor docstring comment !

tests/foreman/ui/test_host.py Outdated Show resolved Hide resolved
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: -k 'test_positive_cockpit' tests/foreman/ui/test_host.py

@shubhamsg199
Copy link
Contributor Author

PRT build 661 is failing with :

selenium.common.exceptions.WebDriverException: Message: Error forwarding the new session Request timed out waiting for a 
node to become available.

@shubhamsg199
Copy link
Contributor Author

shubhamsg199 commented Feb 1, 2022

Test Results:

$ pytest -k test_positive_cockpit tests/foreman/ui/test_host.py
============================================= test session starts ===============================================================
platform linux -- Python 3.8.6, pytest-6.2.5, py-1.10.0, pluggy-0.13.1
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/sganar/satellite/robottelo, configfile: pyproject.toml
plugins: services-2.2.1, mock-3.6.1, reportportal-5.0.8, forked-1.3.0, ibutsu-2.0.1, cov-3.0.0, xdist-2.5.0
collected 36 items / 35 deselected / 1 selected                                                                                                  

tests/foreman/ui/test_host.py .                                                                                                            [100%]

================================== 1 passed, 35 deselected in 1522.19s (0:25:22) ===============================================

@tstrych tstrych self-requested a review February 1, 2022 11:20
Copy link
Contributor

@tstrych tstrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, Looks good 👍

@tstrych
Copy link
Contributor

tstrych commented Feb 1, 2022

Code quality is failing on dependency installation. Not connected to changes in the PR.

@shubhamsg199
Copy link
Contributor Author

Test Results:

$ pytest -k test_positive_cockpit tests/foreman/ui/test_host.py
=========================================== test session starts =====================================================================
platform linux -- Python 3.8.6, pytest-6.2.5, py-1.10.0, pluggy-0.13.1
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/sganar/satellite/robottelo, configfile: pyproject.toml
plugins: services-2.2.1, mock-3.6.1, reportportal-5.0.8, forked-1.3.0, ibutsu-2.0.1, cov-3.0.0, xdist-2.5.0
collected 36 items / 35 deselected / 1 selected                                                                                                                                                                                                                                          

tests/foreman/ui/test_host.py .                                                                                                                                                                                                                                                    [100%]

====================================== 1 passed, 35 deselected in 1609.05s (0:26:49) ======================================================

Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!
@shubhamsg199 I remember there were a few issues with this test for 7.0 earlier, which can be a reason to rebase this for 6.10.z branch, so can you open a backport PR adding this test in master as well?

@tstrych
Copy link
Contributor

tstrych commented Feb 4, 2022

7.0 cockpit has workaround. and I am currently looking at it cause it's part of RHEL 9 initiative. Once I am finished I will let you know @shubhamsg199

@jyejare
Copy link
Member

jyejare commented Feb 8, 2022

Merging this PR. The checks fails are not related to this PR and a separate PR has been opened to take care of this : #9355

@jyejare jyejare merged commit 8f8c425 into SatelliteQE:6.10.z Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.10.z Introduced in or relating directly to Satellite 6.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants